Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More redaction improvements #652

Merged
merged 7 commits into from
May 9, 2022
Merged

More redaction improvements #652

merged 7 commits into from
May 9, 2022

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented May 6, 2022

Part of #607.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #652 (351672c) into main (be2a818) will increase coverage by 0.02%.
The diff coverage is 47.05%.

❗ Current head 351672c differs from pull request most recent head 247ddf5. Consider uploading reports for the commit 247ddf5 to get more accurate results

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   73.45%   73.47%   +0.02%     
==========================================
  Files         101      102       +1     
  Lines       15161    15157       -4     
==========================================
+ Hits        11136    11137       +1     
+ Misses       4025     4020       -5     
Impacted Files Coverage Δ
crates/matrix-sdk-base/src/rooms/mod.rs 58.91% <ø> (+2.33%) ⬆️
crates/matrix-sdk/src/encryption/mod.rs 27.16% <ø> (ø)
crates/matrix-sdk-base/src/rooms/members.rs 32.14% <25.00%> (+4.87%) ⬆️
crates/matrix-sdk-base/src/store/ambiguity_map.rs 84.14% <33.33%> (ø)
crates/matrix-sdk-base/src/utils.rs 43.47% <43.47%> (ø)
crates/matrix-sdk-base/src/rooms/normal.rs 80.46% <100.00%> (+0.05%) ⬆️
crates/matrix-sdk-base/src/store/memory_store.rs 93.81% <100.00%> (ø)
crates/matrix-sdk-sled/src/state_store.rs 83.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2a818...247ddf5. Read the comment docs.

@jplatte jplatte requested a review from a team May 9, 2022 09:06
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jplatte jplatte merged commit 0fad7b6 into main May 9, 2022
@jplatte jplatte deleted the jplatte/redactions branch May 9, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants