Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): Fix regression #664

Merged
merged 1 commit into from
May 11, 2022
Merged

fix(sdk): Fix regression #664

merged 1 commit into from
May 11, 2022

Conversation

JCWasmx86
Copy link
Contributor

@JCWasmx86 JCWasmx86 commented May 11, 2022 •
edited
Loading

Minor bugfix that otherwise would have exploded, I'm so sorry

Blocks #665

@gnunicorn
Copy link
Contributor

the release is already out. Gotta patch-release this separately.

@gnunicorn gnunicorn mentioned this pull request May 11, 2022
Closed
6 tasks
@gnunicorn gnunicorn merged commit 5570181 into matrix-org:main May 11, 2022
@jplatte
Copy link
Collaborator

jplatte commented May 11, 2022 •
edited
Loading

Before we publish this as 0.5.1, let's also change false to true in map_or. I don't think events without a sender should ever be in the timeline, but I think it makes sense to default to assuming a sender that's not the user themselves then.

@jplatte jplatte mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnunicorn gnunicorn gnunicorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JCWasmx86 @gnunicorn @jplatte