Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for rustls #89

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add feature flag for rustls #89

merged 2 commits into from
Aug 24, 2020

Conversation

tilosp
Copy link
Contributor

@tilosp tilosp commented Aug 21, 2020

No description provided.

Signed-off-by: Tilo Spannagel <development@tilosp.de>
Signed-off-by: Tilo Spannagel <development@tilosp.de>
@tilosp
Copy link
Contributor Author

tilosp commented Aug 21, 2020

@poljar is there any reason for running the ci twice, once on travis-ci.com and once on travis-ci.org.
If there is no reason this repo should be disabled on travis-ci.org, since travis-ci.com will replace it eventually and has more features.

@tilosp tilosp marked this pull request as ready for review August 21, 2020 17:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   75.70%   75.71%   +0.01%     
==========================================
  Files          31       31              
  Lines        6865     6865              
==========================================
+ Hits         5197     5198       +1     
+ Misses       1668     1667       -1     
Impacted Files Coverage Δ
matrix_sdk_crypto/src/verification/sas/helpers.rs 84.68% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176181b...a57c615. Read the comment docs.

@poljar
Copy link
Contributor

poljar commented Aug 21, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   75.70%   75.71%   +0.01%     
==========================================
  Files          31       31              
  Lines        6865     6865              
==========================================
+ Hits         5197     5198       +1     
+ Misses       1668     1667       -1     

Impacted Files Coverage Δ
matrix_sdk_crypto/src/verification/sas/helpers.rs 84.68% <0.00%> (+0.45%) arrow_up

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176181b...a57c615. Read the comment docs.

We're using proptest for some of our tests, so sometimes a test run has a lower coverage, sometimes a bit higher.

@poljar
Copy link
Contributor

poljar commented Aug 24, 2020

@poljar is there any reason for running the ci twice, once on travis-ci.com and once on travis-ci.org.
If there is no reason this repo should be disabled on travis-ci.org, since travis-ci.com will replace it eventually and has more features.

I didn't have the rights to change CI settings and forgot to check after, I think I disabled now the .org one.

@poljar poljar merged commit a5f06f7 into matrix-org:master Aug 24, 2020
@tilosp tilosp deleted the rustls branch August 24, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants