feat(crypto-js): Implement the Attachment API #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the `Attachment.encrypt` and `Attachment.decrypt` methods, along with its `EncryptedAttachment` companion. The trick is to avoid copies as much as possible. Instead of dealing with `Uint8Array` as I've initially done, `&[u8]` and `Vec<u8>` is passed instead. `wasm-bindgen` is smart enough to do as few copies as possible (from JavaScript to Wasm's memory is required, and we don't want to do more), while typing everything as `Uint8Array`. `EncryptedAttachment.encryptedData` returns a copy of the data everytime it is called, and that's the last copy I'm not happy with.
Codecov Report
@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 110 110
Lines 15806 15806
=======================================
Hits 12698 12698
Misses 3108 3108 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hywan
changed the title
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
Attachment.encryptandAttachment.decryptmethods,along with its
EncryptedAttachmentcompanion.The trick is to avoid copies as much as possible. Instead of dealing
with
Uint8Arrayas I've initially done,&[u8]andVec<u8>ispassed instead.
wasm-bindgenis smart enough to do as few copies aspossible (from JavaScript to Wasm's memory is required, and we don't
want to do more), while typing everything as
Uint8Array.EncryptedAttachment.encryptedDatareturns a copy of the dataeverytime it is called, and that's the last copy I'm not happy with.