Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncertainty on what matrix.to URIs look like with v3 events #1867

Closed
turt2live opened this issue Feb 8, 2019 · 5 comments
Closed

Uncertainty on what matrix.to URIs look like with v3 events #1867

turt2live opened this issue Feb 8, 2019 · 5 comments
Assignees
Labels
c2s r0.5.0 Part of the r0.5.0 goal (and related releases) clarification An area where the spec could do with being more explicit

Comments

@turt2live
Copy link
Member

Should probably leave it as-is (https://matrix.to/#/!somewhere:example.org/$hash/with/slashes), but we may want to consider something else

@turt2live turt2live added the clarification An area where the spec could do with being more explicit label Feb 8, 2019
@KitsuneRal
Copy link
Member

Why would it change? Is it because slashes now can be but not necessarily are percent-escaped?

@turt2live
Copy link
Member Author

Yea, it's an argument of figuring out if clients are too smart in parsing links. If they are, they'll break because of slashes.

@erikjohnston
Copy link
Member

Is there a reason not to url encode it? That feels like something we should do anyway (don't we do that if we specify a room alias in there?)

@turt2live
Copy link
Member Author

We don't currently specify that it is url encoded for anything. We treat it as a protocol uri (specifically saying it's not really a url), so there is some argument to saying it isn't encoded.

@erikjohnston
Copy link
Member

But it is used as a uri, so not using the same rules feels like its going to result in issues

@turt2live turt2live self-assigned this Feb 11, 2019
@turt2live turt2live added the c2s r0.5.0 Part of the r0.5.0 goal (and related releases) label Feb 11, 2019
turt2live added a commit that referenced this issue Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c2s r0.5.0 Part of the r0.5.0 goal (and related releases) clarification An area where the spec could do with being more explicit
Projects
None yet
Development

No branches or pull requests

3 participants