-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for Identity service bulk lookup #1040
Conversation
Can one of the admins verify this patch? |
@matrixbot: test this please |
@maxidor: this appears to be a superset of #1039: is that deliberate? |
No worries. if we handle #1039 then we can probably get this one into a state where it can be reviewed separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise I think this looks good, thanks! Don't forget signoff.
api/identity/lookup.yaml
Outdated
@@ -84,3 +84,56 @@ paths: | |||
signatures: | |||
type: object | |||
description: The signatures of the verifying identity services which show that the association should be trusted, if you trust the verifying identity services. | |||
"/bulk_lookup": | |||
post: | |||
summary: Lookup Matrix user IDs for a list of 3pid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3pids (plural)
api/identity/lookup.yaml
Outdated
items: | ||
type: string | ||
title: 3PID medium or address | ||
description: an array of array containing the `3PID Medium type`_ in first position and the 3PID Address in second position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array of arrays
Oh, and also changelog entries would be great (we should get into the habit of adding them as we go) |
Signed-off-by: Maxime Dor @ Kamax.io (no email to avoid spam) |
@dbkr There is currently no changelog since this never had a released version. Not sure how to proceed further on that one. |
@dbkr Fixed spelling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but blocked on #1039 as it includes those changes.
Closing following required #1039 being closed. |
Can one of the admins verify this patch? |
* Italicise primes and brackets in state res desc I don't like it but it seems to make things look decent in Firefox. This is probably good enough---we're not Knuth, after all. Additionally I have avoided the use of `*E*'s` as in "E's prev_events" since the apostrophe looks poor here. Resolves matrix-org#774. An alternative to matrix-org#1040. * Changelog
No description provided.