Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for Identity service bulk lookup #1040

Closed
wants to merge 3 commits into from
Closed

Add spec for Identity service bulk lookup #1040

wants to merge 3 commits into from

Conversation

maxidorius
Copy link
Contributor

No description provided.

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@richvdh
Copy link
Member

richvdh commented Oct 26, 2017

@matrixbot: test this please

@richvdh
Copy link
Member

richvdh commented Oct 26, 2017

@maxidor: this appears to be a superset of #1039: is that deliberate?

@maxidorius
Copy link
Contributor Author

@richvdh There is a shared appendices, but I didn't expect the PR to show up like this. Do you want me to split? This is still a logical piece if we close #1039

@richvdh
Copy link
Member

richvdh commented Oct 26, 2017

No worries. if we handle #1039 then we can probably get this one into a state where it can be reviewed separately

@richvdh
Copy link
Member

richvdh commented Oct 26, 2017

@dbkr perhaps you could look at this one when you're done with #1039 😇

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise I think this looks good, thanks! Don't forget signoff.

@@ -84,3 +84,56 @@ paths:
signatures:
type: object
description: The signatures of the verifying identity services which show that the association should be trusted, if you trust the verifying identity services.
"/bulk_lookup":
post:
summary: Lookup Matrix user IDs for a list of 3pid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3pids (plural)

items:
type: string
title: 3PID medium or address
description: an array of array containing the `3PID Medium type`_ in first position and the 3PID Address in second position.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array of arrays

@dbkr
Copy link
Member

dbkr commented Oct 26, 2017

Oh, and also changelog entries would be great (we should get into the habit of adding them as we go)

@maxidorius
Copy link
Contributor Author

Signed-off-by: Maxime Dor @ Kamax.io (no email to avoid spam)

@maxidorius
Copy link
Contributor Author

@dbkr There is currently no changelog since this never had a released version. Not sure how to proceed further on that one.

@maxidorius
Copy link
Contributor Author

@dbkr Fixed spelling

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but blocked on #1039 as it includes those changes.

@maxidorius
Copy link
Contributor Author

Closing following required #1039 being closed.

@maxidorius maxidorius closed this Oct 27, 2017
@maxidorius maxidorius deleted the is/bulk_lookup-fix branch October 27, 2017 19:09
@maxidorius maxidorius restored the is/bulk_lookup-fix branch October 27, 2017 20:25
@maxidorius maxidorius reopened this Oct 27, 2017
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@maxidorius maxidorius closed this Nov 8, 2017
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this pull request Aug 22, 2023
* Italicise primes and brackets in state res desc

I don't like it but it seems to make things look decent in Firefox.
This is probably good enough---we're not Knuth, after all.

Additionally I have avoided the use of `*E*'s` as in "E's prev_events"
since the apostrophe looks poor here.

Resolves matrix-org#774.
An alternative to matrix-org#1040.

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants