Dedicate a section on how to use access tokens #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Aug 15, 2018
| support: | ||
|
|
||
| 1. Via a query string parameter, ``access_token=TheTokenHere``. | ||
| #. Via a request header, ``Authorization: Bearer TheTokenHere``. |
There was a problem hiding this comment.
I suspect we should specify when to use which. i.e. to spell out that the query string is for compatibility, but the request header is the preferred approach to avoid access_tokens being leaked in URLs or HTTP access logs.
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 20, 2018
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
…en submitting reports (matrix-org#1517) * Add MSC2249 support * changelog * Add a line on verification * Changes based on review feedback * Apply suggestions from code review Co-authored-by: Travis Ralston <travpc@gmail.com> * move tags field to the bottom of report_content.yaml * fix duplicated content now how did that happen * fix up the 404 response schema it wasn't displaying correctly in the rendered spec otherwise * remove erroneous schema reference * 1.7 -> 1.8 Co-authored-by: Travis Ralston <travpc@gmail.com> --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Travis Ralston <travpc@gmail.com> Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check.
This is an attempt to add more clarity to the section, as requested in #1042.
Fixes #1042.