Encourage appservices to use the Authorization header #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also throws in a mention about how to handle a request with a lack of user_id. The request samples now encourage the use of the header over the query string, and have had their sample values added for some readability. Fixes matrix-org#1296 Fixes matrix-org#1424
11 tasks
richvdh
reviewed
Aug 20, 2018
| @@ -192,22 +192,28 @@ they wish to be acting on behalf of. For real users, this would require | |||
| additional permissions granting the AS permission to masquerade as a matrix user. | |||
There was a problem hiding this comment.
this paragraph (github won't let me comment on the offending line) contains a bunch of "wouldn't it be nice if" words rather than "this is how it is". Likewise there is some "this will happen" below which makes this sound like a proposal rather than a statement of fact.
Could you clarify this while you're in the area?
richvdh
approved these changes
Aug 21, 2018
| additional permissions granting the AS permission to masquerade as a matrix user. | ||
| every request. To avoid the application service from having to keep track of each | ||
| user's access token, the application service should identify itself to the Client-Server | ||
| API by providing its ``as_token`` instead for the ``access_token`` alongside the |
There was a problem hiding this comment.
"instead for" sounds wrong. Just "for", maybe?
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 21, 2018
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
* Fix ASCII art alignment Signed-off-by: Michael Kohler <me@michaelkohler.info> Fixes matrix-org#1430 * Add changelog --------- Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check.
This also throws in a mention about how to handle a request with a lack of user_id.
The request samples now encourage the use of the header over the query string, and have had their sample values added for some readability.
Fixes #1296
Fixes #1424