Clarify how external_url is supposed to work #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Aug 30, 2018
| clients to link into the 'native' client from which the event originated. | ||
| For instance, this could contain the message-ID for emails/nntp posts, or a link | ||
| to a blog comment when bridging blog comment traffic in & out of Matrix. | ||
| Clients should provide users with a way to access the ``external_url`` if it |
There was a problem hiding this comment.
Small nag to make sure the client gives adequete warning that it is external and could be a hyperlink to https://weirdpornrus.xxx.bad
August 2018 r0
automation
moved this from In review (just the PRs)
to Reviewer approved
Aug 30, 2018
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check
Fixes #1624