Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MSC1762: Support user-owned identifiers as new 3PID type #1762

Draft
wants to merge 7 commits into
base: old_master
Choose a base branch
from

Conversation

friedger
Copy link

@friedger friedger commented Dec 28, 2018

@friedger friedger changed the title [WIP] Support user-owned identifiers as new 3PID type [WIP] MSC1762: Support user-owned identifiers as new 3PID type Dec 28, 2018
Copy link
Contributor

@maxidorius maxidorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this proposal start on a good idea but its execution is off, mostly because it mixes/misses several independent problems which could each deserve their own MSC potentially:

  • Defining a new 3PID type
  • Defining how such 3PID can be validated by an Identity server within an association session
  • Defining how such 3PID can be added to the Homeserver user's administrative contacts
  • Defining if and how this new 3PID can be used with Homeserver authentication

proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
proposals/1762-3pid-did.md Outdated Show resolved Hide resolved
@friedger
Copy link
Author

@maxidor Thank you for your input!

I have removed the parts relevant to the authentication flow and just mentioned a potential authentication flow as a motivation for adding DIDs as a new 3PID type.

I hope to address your comments about authentication in the new MSC for authentication.

@turt2live turt2live added proposal A matrix spec change proposal proposal-pr T-Core labels Dec 29, 2018
@maxidorius
Copy link
Contributor

@friedger Looking good! And definitely something that I could turn into concrete implementation. Good work! Looking forward to your other MSC.

@richvdh richvdh self-requested a review January 2, 2019 07:16
@friedger
Copy link
Author

friedger commented Jan 6, 2019

Signed-off-by: Friedger Müffke mail@friedger.de

@friedger
Copy link
Author

friedger commented Jan 7, 2019

@turt2live @maxidor I have resolved the open conversations with comments.

@friedger
Copy link
Author

friedger commented Jan 7, 2019

  • Defining how such 3PID can be validated by an Identity server within an association session
  • Defining how such 3PID can be added to the Homeserver user's administrative contacts

These require new MSCs.

@richvdh richvdh removed their request for review February 27, 2019 11:10
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff and removed proposal-pr labels Apr 20, 2020
@turt2live turt2live marked this pull request as draft April 8, 2021 23:37
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants