Skip to content

MSC:1819 Remove Presence Lists#1819

Merged
turt2live merged 4 commits intomasterfrom
neilj/msc-remove-presence-lists
Feb 1, 2019
Merged

MSC:1819 Remove Presence Lists#1819
turt2live merged 4 commits intomasterfrom
neilj/msc-remove-presence-lists

Conversation

@neilisfragile
Copy link
Copy Markdown
Contributor

@neilisfragile neilisfragile commented Jan 28, 2019

@neilisfragile neilisfragile changed the title MSC 1819 Remove Presence Lists MSC:1819 Remove Presence Lists Jan 28, 2019
@neilisfragile neilisfragile requested a review from a team January 28, 2019 18:02
@turt2live turt2live added proposal-in-review proposal A matrix spec change proposal labels Jan 28, 2019
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Jan 28, 2019

In the interest of getting this in for r0 (and because it looks great to me - thank you!):

@mscbot fcp merge

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Jan 28, 2019 •
edited by dbkr
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jan 28, 2019
@neilisfragile neilisfragile mentioned this pull request Jan 28, 2019
Merged
@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 28, 2019
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Jan 28, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

richvdh
richvdh reviewed Jan 29, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we be clear exactly what we are removing from the spec? I assume it's POST /_matrix/client/r0/presence/list/{userId} and GET /_matrix/client/r0/presence/list/{userId}?

(as a matter of preference for future reference: please wrap docs at 80 characters so that they are easier to review)

Comment thread proposals/1819-remove-presence-lists.md Outdated
Comment thread proposals/1819-remove-presence-lists.md Outdated

The proposal is to simply remove references to presence lists with a view to revisiting the same ideas in the future.

This MSC addresses [#1810](https://github.com/matrix-org/matrix-doc/issues/1810)
Copy link
Copy Markdown
Member

@richvdh richvdh Jan 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This MSC addresses [#1810](https://github.com/matrix-org/matrix-doc/issues/1810)
This MSC addresses [#1810](https://github.com/matrix-org/matrix-doc/issues/1810).

richvdh and others added 3 commits January 30, 2019 10:44
@richvdh @neilisfragile
Update proposals/1819-remove-presence-lists.md
5151aa0 
Co-Authored-By: neilisfragile <neil@matrix.org>
@neilisfragile
Update 1819-remove-presence-lists.md
4f13f52 
Add references to exactly what this proposal would remove
@neilisfragile
hard wrap to 80 chars
2eae933
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 1, 2019

A miscommunication and subsequent timing error on our part has lead to this MSC's FCP not scheduled to clear in time. Given the extensive opportunity for people to review, and our goal to cut a s2s r0 today, we are fast forwarding this FCP to end now. There have been no requested changes while this has been in FCP or before this proposal was even opened.

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. proposal-in-review labels Feb 1, 2019
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 1, 2019

This proposal has also jumped to merged because the spec PR has been reviewed and merged while this has been in FCP. No changes have been made to the MSC, and as such no further changes are required to the spec for this MSC.

@turt2live turt2live merged commit f5134b2 into master Feb 1, 2019
@turt2live turt2live mentioned this pull request Jun 2, 2019
Closed
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@ara4n ara4n mentioned this pull request Feb 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

No one assigned

Labels

disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neilisfragile @turt2live @mscbot @richvdh @KitsuneRal