Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC1840: Typed rooms #1840

Open
wants to merge 8 commits into
base: old_master
Choose a base branch
from

Commits on Feb 3, 2019

  1. Add proposal for room type state event

    Signed-off-by: Jonathan Frederickson <jonathan@terracrypt.net>
    jfrederickson committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    871dd44 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. MSC1840: Remove 'room_type' from example room type keys

    Based on feedback in PR discussion; `room_type` is redundant given the
    context.
    jfrederickson committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8942865 View commit details
    Browse the repository at this point in the history
  2. MSC1840: Change domain.com domains to example.com

    Just for cleanliness here, since domain.com is a real thing.
    jfrederickson committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e68bdfb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    896602a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f5543dc View commit details
    Browse the repository at this point in the history
  5. MSC1840: Add note about default room type assumption

    I'm unclear on whether this should be done by the client on room
    creation or by the server as part of `createRoom`. Open to feedback
    here.
    jfrederickson committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e1ab438 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56ac6a1 View commit details
    Browse the repository at this point in the history
  7. MSC1840: Don't specify an explicit default for untyped rooms

    Initially I was considering the default to be `m.messaging`, but
    @julianfoad brings up a good point that this isn't necessarily a good
    assumption. I'm inclined to leave the decision of what to do with
    untyped rooms up to the clients, while recommending that they set room
    types for new rooms going forward.
    jfrederickson committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    4936ff4 View commit details
    Browse the repository at this point in the history