Fix for the #1865 #1889
Merged
Fix for the #1865 #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested review from
turt2live and
a team
and removed request for
turt2live
richvdh
reviewed
Feb 21, 2019
There was a problem hiding this comment.
looks plausible to me, but it's a shame we're directly duplicating the definitions from api/client-server/definitions/push_ruleset.yaml etc. @turt2live: do you know if there is a way these could be shared to save duplication?
|
Using |
|
Ah yes. there are plenty of examples of APIs which refer to event schemas. @ma1uta: could you rework this to remove the duplication? |
|
@richvdh done. |
KitsuneRal
approved these changes
Feb 27, 2019
|
A changelog (clarification) and this is ready to merge, I guess :) |
|
@richvdh @turt2live @KitsuneRal done. I hope this is enough to merge :) |
richvdh
approved these changes
Feb 28, 2019
|
Lots of green checkmarks compels me to merge this. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the m.push_rules schema.
It needs to check carefully the schema.
Signed-off-by: Anatoly Sablin sablintolya@gmail.com