Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reason property to m.call.hangup #2031

Merged
merged 2 commits into from
May 28, 2019
Merged

Conversation

turt2live
Copy link
Member

Fixes #1689

@turt2live turt2live requested a review from a team May 27, 2019 04:08
@@ -1,6 +1,6 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor's note: ewwwww JSON definition

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested possible improvement, but lgtm otherwise.

event-schemas/schema/m.call.hangup Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from uhoreg May 28, 2019 03:18
@turt2live turt2live merged commit 2cf00fc into master May 28, 2019
@turt2live turt2live deleted the travis/1.0/voip-hangup branch May 28, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec voip hangup reasons
2 participants