Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2181: Add an Error Code for Signaling a Deactivated User #2181

Merged
merged 12 commits into from
Jul 31, 2019
Merged

MSC2181: Add an Error Code for Signaling a Deactivated User #2181

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bf747b6
Add proposal regarding user deactivated err codes
anoadragon453 Jul 16, 2019
7a08bc9
Remove template bit
anoadragon453 Jul 16, 2019
4f54b8b
Update with review comments
anoadragon453 Jul 16, 2019
028ea89
/available
anoadragon453 Jul 16, 2019
7f1e822
Update proposals/2181-user-deactivated-errcode.md
anoadragon453 Jul 19, 2019
c1dd804
Specify /login should have M_USER_DEACTIVATED
anoadragon453 Jul 19, 2019
063261b
Merge branch 'anoa/user_deactivated_msc' of github.com:matrix-org/mat…
anoadragon453 Jul 19, 2019
f3ca033
kill the hashes
anoadragon453 Jul 22, 2019
a126fbb
Implementation details
anoadragon453 Jul 22, 2019
8c993ae
respond to review comments
anoadragon453 Jul 23, 2019
f3358e4
Fix typo
anoadragon453 Jul 26, 2019
502f5d5
Be less wishy-washy
anoadragon453 Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions proposals/2181-user-deactivated-errcode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,25 @@ requests.

This proposal asks to create a new errcode, `M_USER_DEACTIVATED`, that can be
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
returned whenever an action is attempted that requires an activited user, but
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
the authenticating user is deactivated. The recommended HTTP code to return
alongside is `403`.
the authenticating user is deactivated. The HTTP code to return alongside is
`403`.
Half-Shot marked this conversation as resolved.
Show resolved Hide resolved

## Tradeoffs
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

The alternative is to continue returning an `M_FORBIDDEN`, but send back a
different errmsg. This is undesirable as it requires clients to pattern match
on a long phrase that could be minutely changed at any time, breaking
everything.
different errmsg. This is undesirable as clients are supposed to treat the
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
message as an opaque string, and should not be performing any
pattern-matching on it.

## Potential issues

None

## Security considerations
turt2live marked this conversation as resolved.
Show resolved Hide resolved

This would allow users to be able to detect if their account had been
deactivated. This is probably something we'd like to allow though.
While the existence of a user was already public knowledge (one can check if
the User ID is available through `/register`, this proposal would allow any
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
user to be able to detect if a registered account has been deactivated.

## Conclusion

Expand Down