MSC2316: Federation queries to aid with database recovery #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Volk <jason@zemos.net> Signed-off-by: Tulir Asokan <tulir@maunium.net> Signed-off-by: Jason Volk <jason@zemos.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Co-authored-by: Jason Volk <jason@zemos.net> Signed-off-by: Tulir Asokan <tulir@maunium.net> Signed-off-by: Jason Volk <jason@zemos.net>
turt2live
changed the title
|
@turt2live I don't think this is particularly WIP (or at least I hope I marked it ready for review because it was ready for review) |
turt2live
changed the title
auscompgeek
reviewed
May 1, 2020
| value, but SHOULD NOT return more events than the specified value. | ||
|
|
||
| > Note that if a limit is imposed, the selection for *which* member events | ||
| are included in the response is implementation dependent. |
There was a problem hiding this comment.
Should this be changed to prefer including at least the latest join events in each room? Otherwise it would be possible for the response to only include leave events, which by my understanding would not be terribly useful since the server could then think it's not in the rooms for those events.
turt2live
added
the
needs-implementation
|
there was an initial implementation of this at matrix-org/synapse#6230, but it got abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: @jevolk
Rendered