Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2320: Versions information for identity servers #2320

Merged
merged 6 commits into from
Mar 21, 2021

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Oct 15, 2019

@babolivier babolivier changed the title MSCXXXX: Versions information for identity servers MSC2320: Versions information for identity servers Oct 15, 2019
@babolivier babolivier added proposal A matrix spec change proposal proposal-in-review labels Oct 15, 2019
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to consider would be whether or not we actually need this yet on the identity API.

proposals/2320-identity-versions.md Show resolved Hide resolved
proposals/2320-identity-versions.md Outdated Show resolved Hide resolved
proposals/2320-identity-versions.md Outdated Show resolved Hide resolved
proposals/2320-identity-versions.md Outdated Show resolved Hide resolved
@babolivier
Copy link
Contributor Author

Another thing to consider would be whether or not we actually need this yet on the identity API.

The current plan about MSC2265 is to start implement it as an unstable/experimental feature before the MSC is merged because the general opinion is that it's not going to change (or not much) til then. This means that identity servers need to be able to tell clients to case fold email addresses before computing hashes, otherwise email lookups will break, thus this is something we need before being able to ship an implementation (especially the advertisement of unstable features).

@babolivier babolivier dismissed turt2live’s stale review October 15, 2019 15:35

concerns should have been addressed

proposals/2320-identity-versions.md Outdated Show resolved Hide resolved
@babolivier babolivier dismissed turt2live’s stale review November 7, 2019 15:46

Concerns should have been addressed

@babolivier babolivier requested review from a team and turt2live and removed request for a team November 7, 2019 15:47
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review status for posterity

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward now - thanks!

@turt2live
Copy link
Member

I think this is small and ready enough to pass through the phases. I don't think this needs an implementation proof given its size and scope.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Feb 5, 2020

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@mscbot mscbot added the proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. label Apr 24, 2020
@matrix-org matrix-org deleted a comment from mscbot Apr 27, 2020
@richvdh richvdh added this to Awaiting FCP ticks in Spec Core Team Backlog Sep 10, 2020
@anoadragon453 anoadragon453 added this to Ready for FCP ticks in Spec Core Team Backlog Sep 11, 2020
@mscbot
Copy link
Collaborator

mscbot commented Mar 16, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Mar 16, 2021
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Mar 16, 2021
@mscbot
Copy link
Collaborator

mscbot commented Mar 21, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Mar 21, 2021
@turt2live turt2live merged commit a78a8bb into master Mar 21, 2021
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Mar 21, 2021
@turt2live turt2live moved this from In FCP to Done to some definition in Spec Core Team Backlog Mar 23, 2021
@turt2live turt2live self-assigned this Apr 6, 2021
turt2live added a commit that referenced this pull request Apr 6, 2021
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Apr 6, 2021
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 4, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Archived in project
Spec Core Team Backlog
  
Done to some definition
Development

Successfully merging this pull request may close these issues.

None yet

4 participants