Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec MSC2290: 3PID binding split #2328

Merged
merged 2 commits into from Oct 29, 2019
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Oct 24, 2019

Spec PR for MSC2290

This is the last of the identity spec PRs. See #2253 for details.

There are no known deviations from the MSC and implementation in this PR.

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks fine

api/client-server/administrative_contact.yaml Outdated Show resolved Hide resolved
those that it trusts.
the |/register/email/requestToken|_ endpoint. The homeserver should validate
the email itself, either by sending a validation email itself or by using
a service it has control over.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a service it has control over.
a service it trusts.

? (and elswhere) given that people can use vector.im for validation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSC specifically says "control" and explicitly discourages trust.

@turt2live turt2live requested a review from uhoreg October 28, 2019 20:28
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants