Skip to content

MSC2414: Make reason and score parameters optional for reporting content#2414

Merged
turt2live merged 9 commits into
matrix-org:masterfrom
iinuwa:master
Oct 7, 2020
Merged

MSC2414: Make reason and score parameters optional for reporting content#2414
turt2live merged 9 commits into
matrix-org:masterfrom
iinuwa:master

Conversation

@iinuwa

@iinuwa iinuwa commented Jan 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rendered
Signed-off-by: Isaiah Inuwa isaiah.inuwa@gmail.com

@iinuwa iinuwa changed the title MSC0000: Make reason optional for reporting content MSC2414: Make reason optional for reporting content Jan 18, 2020
@turt2live

turt2live commented Jan 18, 2020

Copy link
Copy Markdown
Member

For later in the process: this will need sign-off so we can merge it to the repo.

@turt2live turt2live added proposal A matrix spec change proposal. Process state. proposal-in-review labels Jan 18, 2020
@aaronraimist

aaronraimist commented Jan 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

While this is being modified does it make sense to also make score optional (or remove it altogether)? https://github.com/matrix-org/matrix-doc/issues/2224

@Half-Shot

Half-Shot commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

Honestly I'm in favor of removing score unless we can find a client author that has or wants to implement it. Everyone seems to hardcode the score...

@anoadragon453

anoadragon453 commented Jan 29, 2020

Copy link
Copy Markdown
Member

Yeah, would be better to make it optional such that if a client does ever start using score, other clients wouldn't pollute it by sending the min or max score every time.

anoadragon453
anoadragon453 previously requested changes Jan 29, 2020
View reviewed changes
Comment thread proposals/2414-optional-content-reporting-reason.md Outdated
turt2live
turt2live requested changes Mar 27, 2020
View reviewed changes

@turt2live turt2live left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I echo anoa's concerns here.

Comment thread proposals/2414-optional-content-reporting-reason.md Outdated
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@turt2live turt2live self-requested a review June 20, 2020 04:03
turt2live
turt2live approved these changes Aug 26, 2020
View reviewed changes

@turt2live turt2live left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this requires an implementation to support it.

turt2live
turt2live reviewed Aug 26, 2020
View reviewed changes
Comment thread proposals/2414-optional-content-reporting-reason.md Outdated
@turt2live

turt2live commented Aug 26, 2020

Copy link
Copy Markdown
Member

@mscbot fcp merge

@mscbot

mscbot commented Aug 26, 2020 •
edited by KitsuneRal
Loading

Copy link
Copy Markdown
Collaborator

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge Process state. proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels Aug 26, 2020
Half-Shot
Half-Shot reviewed Sep 21, 2020
View reviewed changes
Comment thread proposals/2414-optional-content-reporting-reason.md Outdated
@iinuwa iinuwa changed the title MSC2414: Make reason optional for reporting content MSC2414: Make reason and score parameters optional for reporting content Sep 23, 2020
@turt2live turt2live self-requested a review September 23, 2020 22:05
@anoadragon453 anoadragon453 self-requested a review September 25, 2020 14:37
@turt2live turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Oct 7, 2020
@turt2live turt2live merged commit 9e66d32 into matrix-org:master Oct 7, 2020
@turt2live turt2live self-assigned this Oct 7, 2020
@wbamberg wbamberg mentioned this pull request Oct 7, 2020
Merged
@turt2live

turt2live commented Oct 7, 2020

Copy link
Copy Markdown
Member

Spec PR: #2807

@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Oct 7, 2020
@turt2live

turt2live commented Oct 7, 2020

Copy link
Copy Markdown
Member

Merged 🎉

@anoadragon453 anoadragon453 mentioned this pull request Oct 15, 2020
Closed
govynnus added a commit to govynnus/synapse that referenced this pull request May 27, 2021
@govynnus
Make reason and score optional for report_event
7eb2543 
Implements MSC2414: matrix-org/matrix-spec-proposals#2414

Signed-off-by: Callum Brown <callum@calcuode.com>
@govynnus govynnus mentioned this pull request May 27, 2021
Merged
@zecakeh zecakeh mentioned this pull request Feb 22, 2022
Merged
@S7evinK S7evinK mentioned this pull request Sep 28, 2023
Open
13 tasks
@Johennes Johennes mentioned this pull request Aug 26, 2024
Merged
3 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
13 tasks
@zecakeh zecakeh mentioned this pull request Nov 30, 2024
Closed
26 tasks
@Johennes Johennes mentioned this pull request Jan 2, 2025
Closed
43 tasks
@Johennes Johennes mentioned this pull request Mar 27, 2025
Merged
@Half-Shot Half-Shot mentioned this pull request Apr 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbkr dbkr dbkr left review comments

@turt2live turt2live turt2live approved these changes

@Half-Shot Half-Shot Half-Shot left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@KitsuneRal KitsuneRal KitsuneRal approved these changes

+1 more reviewer

@jplatte jplatte jplatte left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@iinuwa @turt2live @aaronraimist @Half-Shot @anoadragon453 @mscbot @jplatte @dbkr @KitsuneRal @richvdh