Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2425: Remove Authentication on /submitToken Identity Service API #2425

Open
wants to merge 1 commit into
base: old_master
Choose a base branch
from

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 24, 2020

@anoadragon453 anoadragon453 added proposal-in-review proposal labels Jan 24, 2020
@anoadragon453 anoadragon453 force-pushed the anoa/no_auth_on_submit_token branch from d6434ee to 564252b Compare Jan 24, 2020
@anoadragon453 anoadragon453 changed the title Remove Authentication on /submitToken Identity Service API MSC2425: Remove Authentication on /submitToken Identity Service API Jan 24, 2020
@anoadragon453
Copy link
Member Author

@anoadragon453 anoadragon453 commented Mar 23, 2020

Just testing mscbot :)

@mscbot fcp cancel

@mscbot
Copy link
Collaborator

@mscbot mscbot commented Mar 23, 2020

This proposal is not in FCP.

@turt2live turt2live self-requested a review Mar 27, 2020
@turt2live turt2live added the kind:maintenance label Apr 20, 2020
Copy link
Member

@turt2live turt2live left a comment

Otherwise lgtm. Like other MSCs, this needs a backwards compatibility section.

implementations of v2 3PID validation) already operate this way. The spec is
just wrong here.
Copy link
Member

@turt2live turt2live Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec is just wrong here

citation needed - please point to the MSC where the spec incorrectly inferred that authentication is required on these endpoints (which would make this MSC not needed) or remove this claim.

@turt2live turt2live added the needs-implementation label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance needs-implementation proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants