Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2425: Remove Authentication on /submitToken Identity Service API #2425

Open
wants to merge 1 commit into
base: old_master
Choose a base branch
from
Open

MSC2425: Remove Authentication on /submitToken Identity Service API #2425

wants to merge 1 commit into from

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 24, 2020 •
edited
Loading

@anoadragon453 anoadragon453 added proposal-in-review proposal A matrix spec change proposal labels Jan 24, 2020
@anoadragon453 anoadragon453 changed the title Remove Authentication on /submitToken Identity Service API MSC2425: Remove Authentication on /submitToken Identity Service API Jan 24, 2020
@anoadragon453
Copy link
Member Author

Just testing mscbot :)

@mscbot fcp cancel

@mscbot
Copy link
Collaborator

mscbot commented Mar 23, 2020

This proposal is not in FCP.

@turt2live turt2live self-requested a review March 27, 2020 02:49
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
turt2live
turt2live requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm. Like other MSCs, this needs a backwards compatibility section.

proposals/2425-no-auth-on-submit-token.md
Comment on lines +30 to +31
implementations of v2 3PID validation) already operate this way. The spec is
just wrong here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec is just wrong here

citation needed - please point to the MSC where the spec incorrectly inferred that authentication is required on these endpoints (which would make this MSC not needed) or remove this claim.

@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@anoadragon453 anoadragon453

Labels
kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anoadragon453 @mscbot @turt2live