Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2474: Add key backup version to SSSS account data #2474

Open
wants to merge 2 commits into
base: old_master
Choose a base branch
from
Open

MSC2474: Add key backup version to SSSS account data #2474

wants to merge 2 commits into from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Mar 26, 2020 •
edited by ara4n
Loading

@uhoreg uhoreg changed the title MSCxxxx: Add key backup version to SSSS account data MSC2474: Add key backup version to SSSS account data Mar 26, 2020
@ara4n
Copy link
Member

ara4n commented Mar 26, 2020

lgtm

@turt2live turt2live added the proposal A matrix spec change proposal label Mar 26, 2020
@turt2live turt2live self-requested a review March 27, 2020 02:45
turt2live
turt2live approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a version number to me.

proposals/2474-backup-version-in-ssss.md
Comment on lines +37 to +38
When clients see this field, they can use it to determine which backup version
it is for.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to define a format for the version? Also does it need to be an integer in a string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would just be whatever the homeserver returns as the version.

Copy link
Contributor

@manuroe manuroe May 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should define a format to help implementations for typed languages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an opaque string.

@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
@jryans jryans mentioned this pull request Apr 28, 2020
Open
@manuroe manuroe mentioned this pull request Apr 29, 2020
Open
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuroe manuroe manuroe left review comments

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uhoreg @ara4n @turt2live @manuroe