MSC2474: Add key backup version to SSSS account data #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
changed the title
|
lgtm |
turt2live
approved these changes
Mar 31, 2020
Comment on lines
+37
to
+38
| When clients see this field, they can use it to determine which backup version | ||
| it is for. |
There was a problem hiding this comment.
Do we need to define a format for the version? Also does it need to be an integer in a string?
There was a problem hiding this comment.
It would just be whatever the homeserver returns as the version.
There was a problem hiding this comment.
We should define a format to help implementations for typed languages.
turt2live
added
the
needs-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered