Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2540: Stricter event validation: JSON compliance #2540

Merged
merged 10 commits into from
May 25, 2020
Merged

MSC2540: Stricter event validation: JSON compliance #2540

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7797c18
Add MSC2540 for stricter validation of event JSON.
clokep May 13, 2020
11587a5
Small clarification.
clokep May 13, 2020
bbbd9c4
Update wording to avoid demand-style language.
clokep May 13, 2020
03588cb
Be clearer about errors and what to do with current room versions.
clokep May 13, 2020
6757c60
Specify the current stable room versions.
clokep May 14, 2020
0b6301a
Fix grammar and typos from review.
clokep May 15, 2020
007c8b5
Clarify the range of valid values.
clokep May 15, 2020
e5fa76c
Clarify range a bit more.
clokep May 15, 2020
f5ebe33
Reword how bad values are handled.
clokep May 19, 2020
0771671
Give more guidance on how invalid events should be handled.
clokep May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions proposals/2540-stricter-event-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,26 @@ even support these by default. One common additional feature is handling

## Proposal
turt2live marked this conversation as resolved.
Show resolved Hide resolved

In a future room version, Matrix server implementations are to strictly enforce
the JSON compliance of the Canonical JSON specification for events.
In a future room version, homeserver implementations are to strictly enforce
the JSON compliance of the Canonical JSON specification for events. Events that
do not abide by these rules should be rejected with the error code `M_NOT_JSON`.
clokep marked this conversation as resolved.
Show resolved Hide resolved
clokep marked this conversation as resolved.
Show resolved Hide resolved

The rationale for doing this in a future room version is to avoid a split brain
room -- where some federated servers believe an event is valid and others reject
it as invalid. Rooms will be able to opt into this behavior as part of a room
version upgrade.

Homeserver implementations are not to strictly enforce this JSON compliance in
[stable room versions](https://matrix.org/docs/spec/#complete-list-of-room-versions).
clokep marked this conversation as resolved.
Show resolved Hide resolved
The rationale is essentially the same as why a future room version is necessary,
clokep marked this conversation as resolved.
Show resolved Hide resolved
this ensures that all federated servers treat the same events as valid.


## Potential issues

N/A
Homeserver implementations might include JSON parsers which are stricter than
others. It may not be worthwhile or reasonable to loosen those restrictions for
stable room versions.


## Alternatives
Expand Down