Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2705: Animated thumbnails for media #2705

Merged
merged 5 commits into from
Feb 11, 2024
Merged

MSC2705: Animated thumbnails for media #2705

merged 5 commits into from
Feb 11, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 28, 2020 •
edited by richvdh
Loading

Rendered

Implementations:

FCP tickyboxes

@turt2live turt2live added proposal-in-review proposal A matrix spec change proposal kind:feature MSC for not-core and not-maintenance stuff labels Jul 28, 2020
Sorunome
Sorunome reviewed Jul 31, 2020
View reviewed changes
proposals/2705-thumbnail-requirements.md Outdated Show resolved Hide resolved
proposals/2705-thumbnail-requirements.md Outdated Show resolved Hide resolved
proposals/2705-thumbnail-requirements.md Outdated Show resolved Hide resolved
proposals/2705-thumbnail-requirements.md Outdated Show resolved Hide resolved
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@turt2live turt2live mentioned this pull request May 5, 2023
Draft
@turt2live turt2live changed the title MSC2705: Animated thumbnails for media (and thumbnail content-type requirements) MSC2705: Animated thumbnails for media Dec 16, 2023
@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 16, 2023
@turt2live
Copy link
Member Author

I've dropped the confusing language around thumbnailing support minimums from this MSC in an effort to get it over the line. A different MSC will have to define the expected content types for /thumbnail (both what can be thumbnailed, and what should be returned).

I'm also proposing to push this forward through the spec. It's been implemented for several years at this point, and seems to be serving communities well. Client support is still lacking, though this appears to be due to lack of bandwidth rather than a decision not to do it. Some clients do support it, though their implementations are not backreferenced (client authors: please backreference!).

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Dec 16, 2023 •
edited by KitsuneRal
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Dec 16, 2023
@turt2live turt2live added this to Ready for FCP ticks in Spec Core Team Backlog Dec 21, 2023
uhoreg
uhoreg reviewed Jan 9, 2024
View reviewed changes
proposals/2705-thumbnail-requirements.md
* `image/webp`

The returned content type for an animated thumbnail is additionally left as an implementation detail,
though servers SHOULD use `image/webp` whenever possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I'd just leave the content type completely up to the implementation, but [shrug]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, #4011 improves this significantly.

@mscbot
Copy link
Collaborator

mscbot commented Feb 5, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 5, 2024
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Feb 6, 2024
@mscbot
Copy link
Collaborator

mscbot commented Feb 10, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Feb 10, 2024
@turt2live turt2live merged commit 4e657e5 into old_master Feb 11, 2024
@turt2live turt2live deleted the travis/msc/animated-thumbnails branch February 11, 2024 04:18
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Feb 11, 2024
@turt2live turt2live moved this from In FCP to Requires spec writing in Spec Core Team Backlog Feb 11, 2024
turt2live added a commit that referenced this pull request Feb 11, 2024
@turt2live @KitsuneRal
MSC2705: Animated thumbnails for media (#2705)
1c38196 
* Proposal to support animated thumbnails

* add implementation note

* Apply suggestions from code review

Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>

* Clean up the MSC

* Appease the keepers of mimetypes

---------

Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
@turt2live turt2live mentioned this pull request Mar 12, 2024
Closed
23 tasks
@turt2live turt2live mentioned this pull request Mar 19, 2024
Merged
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1757

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Mar 19, 2024
@turt2live turt2live moved this from Requires spec writing to Requires spec PR review in Spec Core Team Backlog Mar 19, 2024
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Apr 1, 2024
@turt2live turt2live moved this from Requires spec PR review to Done to some definition in Spec Core Team Backlog Apr 1, 2024
@cyrneko cyrneko mentioned this pull request Apr 7, 2024
Open
This was referenced Apr 19, 2024
Merged
Closed
This was referenced Jul 5, 2024
Closed
Open
@KitsuneRal KitsuneRal mentioned this pull request Jul 17, 2024
Merged
@cyrneko cyrneko mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@Half-Shot Half-Shot Half-Shot left review comments

@Sorunome Sorunome Sorunome left review comments

@KitsuneRal KitsuneRal KitsuneRal left review comments

Assignees
No one assigned
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@turt2live @mscbot @uhoreg @Half-Shot @Sorunome @KitsuneRal