Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2746: Improved VoIP Signalling #2746

Merged
merged 81 commits into from Apr 28, 2023
Merged

MSC2746: Improved VoIP Signalling #2746

merged 81 commits into from Apr 28, 2023

Commits on Aug 21, 2020

  1. Placeholder for reliable VoIP MSC

    @dbkr
    dbkr committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    cf50137 View commit details
    Browse the repository at this point in the history

  2. First version written up

    @dbkr
    dbkr committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    a9b17fc View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Typo 

    Co-authored-by: Matthew Hodgson <matthew@matrix.org>
    @dbkr @ara4n
    dbkr and ara4n committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    37c1f98 View commit details
    Browse the repository at this point in the history

  2. Typo 

    Co-authored-by: Matthew Hodgson <matthew@matrix.org>
    @dbkr @ara4n
    dbkr and ara4n committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    5156caf View commit details
    Browse the repository at this point in the history

  3. Switch to m.call.select_answer

    @dbkr
    dbkr committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    fe8b1eb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Make self-calling possible 

    Replaces `answer_id` with `party_id` and introduces the `invitee`
field on `m.call.invite`.
    @dbkr
    dbkr committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    6c4a077 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Nobody spotted the deliberate typo

    @dbkr
    dbkr committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    25ed29a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Fixes & clarifications from Brendan 

    Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
    @dbkr @babolivier
    dbkr and babolivier committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    bec62ab View commit details
    Browse the repository at this point in the history

  2. answers ID -> party ID

    @dbkr
    dbkr committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    019bcdd View commit details
    Browse the repository at this point in the history

  3. clarify party_id

    @dbkr
    dbkr committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    66179f1 View commit details
    Browse the repository at this point in the history

  4. require that the client tries to decrypt all events before ringing

    @dbkr
    dbkr committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    9e8c829 View commit details
    Browse the repository at this point in the history

  5. not all of these necessary's were necessary

    @dbkr
    dbkr committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    e224af3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    2561820 View commit details
    Browse the repository at this point in the history

  2. line break

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    63cecd1 View commit details
    Browse the repository at this point in the history

  3. workaround markdown being awful

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    c6f6ca1 View commit details
    Browse the repository at this point in the history

  4. specify grammar for IDs

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    e9fe3af View commit details
    Browse the repository at this point in the history

  5. document why not mandate the same device IDs

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    563dba5 View commit details
    Browse the repository at this point in the history

  6. rejection is about what the caller sees, not what's been sent

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    070451e View commit details
    Browse the repository at this point in the history

  7. Explain use of the age field

    @dbkr
    dbkr committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    7bca76e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Clarify party_id / user_id tuple in negotiate events

    @dbkr
    dbkr committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e361fa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Require end-of-candidates candidate

    @dbkr
    dbkr committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    722ee0d View commit details
    Browse the repository at this point in the history

  2. Add alternatives note for trickle ICE discovery mechansim 

    and why it would be (more) awful
    @dbkr
    dbkr committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    8e76616 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. add that chrome spits out icegatheringstatechange

    @dbkr
    dbkr committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7e742d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. clients must accept string version

    @dbkr
    dbkr committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    8da4b7c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Add text on unstable prefixng (and how/why we aren't)

    @dbkr
    dbkr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    18200d0 View commit details
    Browse the repository at this point in the history

  2. Specify what happens when someone leaves the room

    @dbkr
    dbkr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    9e22601 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Rejig m.call.negotiate 

    We need to know what is an offer and what is an answer.
    @dbkr
    dbkr committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a446629 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Explain politness & glare in a simpler way (I hope)

    @dbkr
    dbkr committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    1326a22 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Add note on why we don't allow for ICE before an answer.

    @dbkr
    dbkr committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a669828 View commit details
    Browse the repository at this point in the history

  2. Define WebRTC track & stream configs for calls

    @dbkr
    dbkr committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    0fa0770 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. select_answer was missing a version

    @dbkr
    dbkr committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    599ad3c View commit details
    Browse the repository at this point in the history

  2. Fix old type 

    Co-authored-by: Matthew Hodgson <matthew@matrix.org>
    @dbkr @ara4n
    dbkr and ara4n committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    6478f9d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Clarfy that whatever codecs webrtc say is what goes

    @dbkr
    dbkr committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    b62f842 View commit details
    Browse the repository at this point in the history

  2. Typos 

    Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
    @dbkr @babolivier
    dbkr and babolivier committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    9156c80 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Typo 

    Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de>
    @dbkr @deepbluev7
    dbkr and deepbluev7 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    834bc3b View commit details
    Browse the repository at this point in the history

  2. only allow the number zero as numeric version

    @dbkr
    dbkr committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    ec2c7fe View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Update 2746-reliable-voip.md 

    clarify tense
    @ara4n
    ara4n committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    a572eb8 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Add user_busy hangup / reject reason

    @dbkr
    dbkr committed May 26, 2021
    Configuration menu
    Copy the full SHA
    6592023 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Add capability for DTMF

    @dbkr
    dbkr committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    996adab View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Be clear about versions 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    91428c8 View commit details
    Browse the repository at this point in the history

  2. Clarify clients must respond to m.call.negotiate 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    e42dd41 View commit details
    Browse the repository at this point in the history

  3. Give m.call.negotiate a version 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    29485c4 View commit details
    Browse the repository at this point in the history

  4. Remove repeated words 

    Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
    @SimonBrandner @zecakeh
    SimonBrandner and zecakeh committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    f69ae72 View commit details
    Browse the repository at this point in the history

  5. Be clearer about types 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    51e02b2 View commit details
    Browse the repository at this point in the history

  6. Avoid defining call types 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    312ffe5 View commit details
    Browse the repository at this point in the history

  7. Specify minimal lifetime 

    Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
    @SimonBrandner
    SimonBrandner committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    4617af5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Use MSC1597 grammar for call / party IDs.

    @dbkr
    dbkr committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    289fb3f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Add more rationale around voip event version

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1392eae View commit details
    Browse the repository at this point in the history

  2. Change advice for calls in public rooms.

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    46bfbde View commit details
    Browse the repository at this point in the history

  3. Typo 

    Co-authored-by: Hubert Chathi <hubertc@matrix.org>
    @dbkr @uhoreg
    dbkr and uhoreg committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    9dcda02 View commit details
    Browse the repository at this point in the history

  4. Clarify reject/hangup sending

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    6dc85a8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dbkr/msc2746' of github.com:matrix-org/matrix-spec-prop… 

    …osals into dbkr/msc2746
    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f138bfe View commit details
    Browse the repository at this point in the history

  6. Clarify hangup reason backwards compat

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    2fd97c9 View commit details
    Browse the repository at this point in the history

  7. Clarify party ID

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    04eaee2 View commit details
    Browse the repository at this point in the history

  8. There is no sender field. 

    Also fix typos in previous commit.
    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c52a845 View commit details
    Browse the repository at this point in the history

  9. Require ignoring negotiates not matching party ID 

    Co-authored-by: Hubert Chathi <hubertc@matrix.org>
    @dbkr @uhoreg
    dbkr and uhoreg committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    6dcf65c View commit details
    Browse the repository at this point in the history

  10. Word negotiate events better

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    859cf6d View commit details
    Browse the repository at this point in the history

  11. Don't forget the txn ID is returned by the send call.

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    340e769 View commit details
    Browse the repository at this point in the history

  12. Enumerate all the current VoIP events in 'version' section.

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    8be57ed View commit details
    Browse the repository at this point in the history

  13. Clarify treatment of version numeric 1.

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a09be95 View commit details
    Browse the repository at this point in the history

  14. Clarify that track/stream layout is new. 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5d38f15 View commit details
    Browse the repository at this point in the history

  15. Link to m.call.invite 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    3162911 View commit details
    Browse the repository at this point in the history

  16. Suggestions from richvdh 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    097fa58 View commit details
    Browse the repository at this point in the history

  17. More suggestions from richvdh 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4eaa0b4 View commit details
    Browse the repository at this point in the history

  18. More suggestions from richvdh 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    db5ca80 View commit details
    Browse the repository at this point in the history

  19. Clarify call invite

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    48527fc View commit details
    Browse the repository at this point in the history

  20. Pluralise

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    312cdf7 View commit details
    Browse the repository at this point in the history

  21. Reflect that MSC1597 hasn't landed yet. 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    8286d10 View commit details
    Browse the repository at this point in the history

  22. Politeness only applies to renegotiation

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a5e963f View commit details
    Browse the repository at this point in the history

  23. s/Mandate/define/

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    b09af73 View commit details
    Browse the repository at this point in the history

  24. Remove DTMF capability section to move tov MSC2747.

    @dbkr
    dbkr committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1fc6b37 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Clarify backwards compat 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c9f0574 View commit details
    Browse the repository at this point in the history

  2. Grammar 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    0880475 View commit details
    Browse the repository at this point in the history

  3. Fix quotes 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e45c1e0 View commit details
    Browse the repository at this point in the history

  4. Typo 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    bdf9639 View commit details
    Browse the repository at this point in the history

  5. Remove sentence that I think is now just redundant

    @dbkr
    dbkr committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    082f216 View commit details
    Browse the repository at this point in the history

  6. Clarify mre on type field

    @dbkr
    dbkr committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    ce0e338 View commit details
    Browse the repository at this point in the history

  7. Clarify end-of-candidates

    @dbkr
    dbkr committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2919112 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Add comma 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @dbkr @richvdh
    dbkr and richvdh committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c949b32 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Update 2746-reliable-voip.md (#3992)

    @richvdh
    richvdh committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7d8d527 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. wording changes

    @anoadragon453
    anoadragon453 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    3925586 View commit details
    Browse the repository at this point in the history