-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2774: Expose the widget ID to the widget #2774
Conversation
Implementation: matrix-org/matrix-widget-api@3fdfe4f |
This seems fairly straightforward and no one has really opposed it, so: @mscbot fcp merge |
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine as long as we're happy to stick with the current mechanism for URL templating.
I read https://15631-24998719-gh.circle-artifacts.com/0/scripts/gen/widgets/unstable.html#url-templating (from #2764) and wondered if it needed to be clearer about what escaping is expected: for example, does the client need to care if the param is in the query string or the fragment?
That's orthogonal here though.
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Rendered