MSC3089: File tree structures - #3089
Draft
turt2live wants to merge 3 commits into
Draft
Conversation
turt2live
marked this pull request as draft
April 2, 2021 22:26
turt2live
added
A-Client Server
This comment has been minimized.
This comment has been minimized.
turt2live
commented
Apr 3, 2021
toger5
reviewed
Apr 3, 2021
turt2live
added
the
needs-implementation
turt2live
commented
Jun 10, 2021
| "type": "m.branch", | ||
| "state_key": "$event", | ||
| "content": { | ||
| "active": true |
Member
Author
There was a problem hiding this comment.
note for mostly myself: we include a file name here to make simple edits easier.
edit: as name: string
Member
Author
There was a problem hiding this comment.
also locked: true for file locking
turt2live
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jun 10, 2021
MSC: matrix-org/matrix-spec-proposals#3089 Includes part of MSC3088 (room subtyping): matrix-org/matrix-spec-proposals#3088 The NamespacedValue stuff is borrowed from the Extensible Events implementation PR in the react-sdk as a useful thing to put here. When/if the MSCs become stable, we'd convert the values to enums and drop the constants (or keep them for migration purposes, but switch to stable). This flags the whole thing as unstable because it's highly subject to change.
jryans
reviewed
Jun 12, 2021
| *Author's note: This proposal assumes the reader is familiar with the terminology of the reading | ||
| materials mentioned above.* | ||
|
|
||
| We introduce a new room subtype, `m.data_tree`, to be applied to spaces to denote that they are |
Contributor
There was a problem hiding this comment.
When you say "room subtype" here, should I assume MSC3088 m.room.purpose state events with a state key of m.data_tree? (There's enough MSCs that mention types floating around that I'm having trouble distinguishing them all...)
Member
Author
There was a problem hiding this comment.
yes, sorry. Will leave this open as a reminder to clarify.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Partial implementation: matrix-org/matrix-js-sdk#1732