MSC3269: An error code for busy servers#3269
Draft
Yoric wants to merge 3 commits intomatrix-org:old_masterfrom
Draft
MSC3269: An error code for busy servers#3269Yoric wants to merge 3 commits intomatrix-org:old_masterfrom
Yoric wants to merge 3 commits intomatrix-org:old_masterfrom
Conversation
Signed-off-by: David Teller <davidt@element.io>
uhoreg
reviewed
Jul 6, 2021
uhoreg
changed the title
uhoreg
added
kind:feature
penn5
reviewed
Jul 6, 2021
kevincox
reviewed
Jul 7, 2021
| ## Alternatives | ||
|
|
||
| We could rather decide that `M_RESOURCE_LIMIT_EXCEEDED` can also be used to mean that the user should wait before | ||
| retrying, even if they're not the ones using too many resources. I suspect that this would be confusing, though. |
Contributor
There was a problem hiding this comment.
I think it is important to differentiate between retryable an non-retryable errors, so we should keep these separate.
|
|
||
| This proposal introduces `M_SERVER_BUSY`, to be used when the server is too busy to respond right now, typically | ||
| because a large number of pending requests, and the client should retry later. It is typically designed to be returned | ||
| with a `retry_after_ms`, which hints how long the client should wait before retrying. |
Contributor
There was a problem hiding this comment.
Should they wait before trying this request? Or wait before retrying "similar" requests? Or should the pause all requests until the specified duration?
It seems like this is too little information to go on, especially on batch and expensive operations such as an initial sync.
Dominaezzz
reviewed
Jul 9, 2021
|
|
||
| ## Security considerations | ||
|
|
||
| I can't think of any security issues that this could cause. |
Contributor
There was a problem hiding this comment.
Potential attacker/spammer would programmatically know they've succeeded, although I can't say I know how this information would be useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.