Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3291: Muting in VoIP calls #3291

Merged
merged 22 commits into from
Jul 16, 2023
Merged

MSC3291: Muting in VoIP calls #3291

merged 22 commits into from
Jul 16, 2023

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jul 22, 2021 •
edited by turt2live

@SimonBrandner
MSC: Muting in VoIP calls
78bfa25 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner changed the title MSC: Muting in VoIP calls MSC3291: Muting in VoIP calls Jul 22, 2021
@SimonBrandner
Update MSC number
a3d1abc 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Missing :
57a6330 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Fix MSC number in prefix
7658c4a 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
ara4n
ara4n reviewed Jul 22, 2021
View reviewed changes
proposals/3291-muting.md Outdated Show resolved Hide resolved
ara4n
ara4n reviewed Jul 22, 2021
View reviewed changes
proposals/3291-muting.md Outdated Show resolved Hide resolved
@turt2live turt2live added kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal proposal-in-review voip needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 23, 2021
@SimonBrandner
Fix unstable prefix table
2130df9 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Reword pottential issues
3a9701d 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add an Alternatives section
d809c3b 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
anoadragon453
anoadragon453 reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally sensible so far!

proposals/3291-muting.md Outdated Show resolved Hide resolved
proposals/3291-muting.md Outdated Show resolved Hide resolved
proposals/3291-muting.md Outdated Show resolved Hide resolved
proposals/3291-muting.md Outdated Show resolved Hide resolved
proposals/3291-muting.md Outdated Show resolved Hide resolved
proposals/3291-muting.md Show resolved Hide resolved
SimonBrandner and others added 4 commits July 26, 2021 15:25
@SimonBrandner @anoadragon453
Remove trailing comma
67168b3 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@SimonBrandner @anoadragon453
Fix a typo
ec24d95 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@SimonBrandner
Fix missing word
0c01908 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Link to MSC for holding
cc8b73a 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Update unstable prefixes
f1ac61f 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This was referenced Jul 27, 2021
Merged
Closed
@dbkr dbkr removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Aug 2, 2021
@germain-gg germain-gg mentioned this pull request Aug 11, 2021
Closed
@SimonBrandner SimonBrandner mentioned this pull request Aug 24, 2021
Closed
@SimonBrandner SimonBrandner changed the base branch from old_master to main August 30, 2021 16:00
@SimonBrandner SimonBrandner changed the base branch from main to old_master August 30, 2021 16:00
@turt2live
Copy link
Member

@mscbot resolve review comments up to June 6, 2023

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Jul 4, 2023
@turt2live turt2live removed their request for review July 4, 2023 03:23
richvdh
richvdh reviewed Jul 4, 2023
View reviewed changes
proposals/3291-muting.md Outdated Show resolved Hide resolved
@SimonBrandner @richvdh
Don't refer to something that doesn't exist
4da6f86 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Jul 11, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 11, 2023
@mscbot
Copy link
Collaborator

mscbot commented Jul 16, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 16, 2023
@turt2live turt2live merged commit ab26f19 into matrix-org:old_master Jul 16, 2023
@turt2live turt2live moved this from Ready for FCP ticks to Requires spec writing in Spec Core Team Backlog Jul 16, 2023
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 16, 2023
turt2live pushed a commit that referenced this pull request Aug 4, 2023
@SimonBrandner @anoadragon453
@richvdh @turt2live
MSC3291: Muting in VoIP calls (#3291)
7ad992a 
* MSC: Muting in VoIP calls

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Update MSC number

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Missing :

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Fix MSC number in prefix

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Fix unstable prefix table

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Reword pottential issues

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Add an Alternatives section

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Remove trailing comma

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Fix a typo

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Fix missing word

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Link to MSC for holding

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Update unstable prefixes

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Simplify things

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Be explicit about deps

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Be clearer about how things work

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Update proposals/3291-muting.md

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* `disabled` -> `enabled`

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Fix client mention

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Improve explaination

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Be more precise

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Fix negation

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Don't refer to something that doesn't exist

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@SimonBrandner SimonBrandner deleted the msc/muting branch August 22, 2023 12:07
@turt2live turt2live mentioned this pull request Mar 12, 2024
Closed
23 tasks
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1755

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Mar 19, 2024
@turt2live turt2live moved this from Requires spec writing to Requires spec PR review in Spec Core Team Backlog Mar 19, 2024
@richvdh
Copy link
Member

richvdh commented Mar 26, 2024

Merged! 🎉

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Mar 26, 2024
@richvdh richvdh moved this from Requires spec PR review to Done to some definition in Spec Core Team Backlog Mar 26, 2024
This was referenced Apr 19, 2024
Merged
Closed
@turt2live turt2live mentioned this pull request Jul 5, 2024
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels bwindels left review comments

@kevincox kevincox kevincox left review comments

@dbkr dbkr dbkr left review comments

@ara4n ara4n ara4n left review comments

@richvdh richvdh richvdh left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg

Assignees

@SimonBrandner SimonBrandner

Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal voip
Projects
Spec Core Team Backlog
Status: Done to some definition
[Temp] SCT MSC intake board
Status: Done for now
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@SimonBrandner @dbkr @mscbot @turt2live @richvdh @bwindels @kevincox @uhoreg @ara4n @anoadragon453