MSC3325: Upgrading invite-only rooms#3325
MSC3325: Upgrading invite-only rooms#3325uhoreg wants to merge 4 commits intomatrix-org:old_masterfrom
Conversation
uhoreg
changed the title
uhoreg
added
client-server
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
this is a much cleaner solution
|
|
||
| ## Potential issues | ||
|
|
||
| None? |
There was a problem hiding this comment.
If you upgrade a knocking room like this, you lose the ability to knock, thanks to us having made knocking & restricted access mutually exclusive.
Also, it's not clear whether one should remove the restricted access rule down the line or not, or whether you end up stuck in restricted mode forever.
There was a problem hiding this comment.
Valid point, but the MSC seems to concern itself with invite-only rooms rather than non-public rooms
There was a problem hiding this comment.
I've added a note about the first point.
For the second point, I think we just leave it to the room admins to change the join rule whenever they feel it's appropriate to do so.
There was a problem hiding this comment.
I think there should be a client impl recommendation that clients label the pre-upgraded room specifically in the restricted join rule settings rather than generically by name+avatar as they may do otherwise. E.g members of a prior version of this room are able to join without an invitation or similar
There was a problem hiding this comment.
Is this still a problem now that the knock_restricted join rule exists?
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| @@ -0,0 +1,81 @@ | |||
| # MSC3325: Upgrading invite-only rooms | |||
There was a problem hiding this comment.
What is the advantage of this approach? There are disadvantages listed in this proposal but no advantages.
| version allows both to be used, then this proposal can be extended at that | ||
| time. | ||
|
|
||
| If the room is encrypted, users will not receive the keys to decrypt messages |
There was a problem hiding this comment.
This is a pretty huge issue imho. I'm just wondering how to soon upgrade some encrypted community rooms I'm in that have 800+ members. Most of the members only check messages rarely, which means that a lot of the members would lose messages for a large part of time after the upgrade is triggered up until they join. I'm not entirely sure if there is anything that can be improved regarding this in this MSC, it's probably best to go via the invite way for encrypted invite only rooms with room history set to "invited", but voicing as a +1 to potential issue.
10 participants
Rendered