Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3480: Make device names private #3480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MSC3480: Make device names private #3480

wants to merge 3 commits into from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Nov 9, 2021 •
edited by github-actions bot
Loading

@uhoreg uhoreg changed the title MSCxxxx: Make device names private MSC3480: Make device names private Nov 9, 2021
@uhoreg uhoreg added e2e kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal labels Nov 9, 2021
SimonBrandner
SimonBrandner reviewed Nov 10, 2021
View reviewed changes
proposals/3480-private-device-names.md
https://github.com/matrix-org/matrix-doc/issues/1826. However, having to
manage public and private names could be confusing for a user. In addition,
this would require API changes, whereas making device names private does not
require API changes. (Note that #1826 also suggests making other information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require API changes. (Note that #1826 also suggests making other information
require API changes. (Note that https://github.com/matrix-org/matrix-doc/issues/1826 also suggests making other information

Signed-off-by: Šimon Brandner simon.bra.ag@gmail.com

@uhoreg uhoreg mentioned this pull request Dec 17, 2022
Closed
@c7hm4r c7hm4r mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner left review comments

Assignees
No one assigned
Labels
e2e kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uhoreg @SimonBrandner