Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3567: Allow requesting events from the start/end of the room history #3567

Merged
merged 5 commits into from Jan 16, 2022
Merged

MSC3567: Allow requesting events from the start/end of the room history #3567

merged 5 commits into from Jan 16, 2022

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Dec 14, 2021 •
edited

@clokep clokep mentioned this pull request Dec 14, 2021
Merged
@turt2live turt2live added client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Dec 14, 2021
turt2live
turt2live approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great - just a point of clarity before chucking this through the process.

proposals/3567-optional-from-on-messages.md Outdated Show resolved Hide resolved
proposals/3567-optional-from-on-messages.md Outdated Show resolved Hide resolved
@turt2live turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation Dec 14, 2021
@turt2live turt2live moved this from Needs idea feedback / initial review to Ready for FCP ticks in Spec Core Team Backlog Dec 14, 2021
@turt2live turt2live moved this from Ready for FCP ticks to Proposed for FCP readiness in Spec Core Team Backlog Dec 14, 2021
@clokep @turt2live
Fix typo.
074773b 
Co-authored-by: Travis Ralston <travisr@matrix.org>
@clokep clokep mentioned this pull request Dec 14, 2021
Closed
@turt2live
Copy link
Member

This seems relatively straightforward, and has a concrete use case.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Dec 14, 2021 •
edited by uhoreg

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Dec 14, 2021
@turt2live turt2live moved this from Proposed for FCP readiness to Ready for FCP ticks in Spec Core Team Backlog Dec 14, 2021
richvdh
richvdh reviewed Dec 15, 2021
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying "no", but I've yet to be convinced that this is the best approach.

Honestly, it sounds like a case of "we've implemented this in a way that violates the spec, and now we want to change the spec make it legal".

[a better justification, tbh, is "synapse does it, and it's pointless to try to hold back that tide now"]

proposals/3567-optional-from-on-messages.md Show resolved Hide resolved
proposals/3567-optional-from-on-messages.md Show resolved Hide resolved
proposals/3567-optional-from-on-messages.md Show resolved Hide resolved
@Gnuxie
Copy link
Contributor

Gnuxie commented Dec 15, 2021

Just want to add that this would help us avoid some serious gymnastics we perform in Mjolnir before redacting a user's events https://github.com/matrix-org/mjolnir/blob/main/src/utils.ts#L101-L169

@richvdh
Copy link
Member

richvdh commented Dec 16, 2021

ok, I've been convinced!

germain-gg pushed a commit to matrix-org/matrix-js-sdk that referenced this pull request Dec 17, 2021
Allow empty back pagination token
6617771 
Following new guidance from matrix-org/matrix-spec-proposals#3567
@turt2live
Copy link
Member

@richvdh can I further convince you to check an FCP box? 😇

@richvdh richvdh self-requested a review December 20, 2021 14:26
@clokep clokep mentioned this pull request Dec 21, 2021
Closed
timokoesters
timokoesters reviewed Dec 21, 2021
View reviewed changes
proposals/3567-optional-from-on-messages.md
@@ -0,0 +1,67 @@
# MSC3567: Allow requesting events from the start/end of the room history
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why synapse supports pagination from the start of the room history?

@mscbot
Copy link
Collaborator

mscbot commented Jan 11, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 11, 2022
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Jan 11, 2022
germain-gg added a commit that referenced this pull request Jan 12, 2022
@germain-gg
Marking from parameter as optional
dabbdba 
As per MSC3567, the `from` parameter is now optional for the `/messages` endpoint to allow fetching first or latest room content without having to rely on `/sync`

#3567
@germain-gg germain-gg mentioned this pull request Jan 12, 2022
Closed
@mscbot
Copy link
Collaborator

mscbot commented Jan 16, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 16, 2022
@turt2live turt2live merged commit 21882b6 into main Jan 16, 2022
@turt2live turt2live moved this from In FCP to Done to some definition in Spec Core Team Backlog Jan 16, 2022
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jan 16, 2022
@turt2live
Copy link
Member

Spec PR: #3638

@timokoesters timokoesters mentioned this pull request Jan 19, 2022
Closed
jplatte pushed a commit to jplatte/matrix-spec that referenced this pull request Mar 25, 2022
@germain-gg @jplatte
Marking from parameter as optional
6fb2669 
As per MSC3567, the `from` parameter is now optional for the `/messages` endpoint to allow fetching first or latest room content without having to rely on `/sync`

matrix-org/matrix-spec-proposals#3567
@MadLittleMods MadLittleMods mentioned this pull request Mar 29, 2022
Closed
richvdh pushed a commit to matrix-org/matrix-spec that referenced this pull request Mar 29, 2022
@jplatte
Mark from parameter as optional for /messages (#1002)
f6da709 
As per MSC3567, the `from` parameter is now optional for the `/messages` endpoint to allow fetching first or latest room content without having to rely on `/sync`

matrix-org/matrix-spec-proposals#3567
@clokep
Copy link
Contributor Author

clokep commented Apr 5, 2022

The new spec PR: matrix-org/matrix-spec#1002.

The spec PR was merged so I think the labels need an update here!

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Apr 5, 2022
@MadLittleMods MadLittleMods mentioned this pull request Apr 5, 2022
Closed
@babolivier babolivier mentioned this pull request Apr 13, 2022
Merged
4 tasks
@zecakeh zecakeh mentioned this pull request May 28, 2022
Closed
66 tasks
@clokep clokep deleted the clokep/messages-from branch May 17, 2023 12:22
@S7evinK S7evinK mentioned this pull request Sep 29, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg left review comments

@turt2live turt2live turt2live approved these changes

@deepbluev7 deepbluev7 deepbluev7 left review comments

@timokoesters timokoesters timokoesters left review comments

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/room/${roomID}/messages requires "from" parameter, but should it?
8 participants
@clokep @turt2live @mscbot @Gnuxie @richvdh @germain-gg @deepbluev7 @timokoesters