Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3713: Alleviating ACL exhaustion with ACL Slots #3713
base: main
Are you sure you want to change the base?
MSC3713: Alleviating ACL exhaustion with ACL Slots #3713
Changes from 3 commits
3d03596
18ed216
51cf6d1
5cdbb6f
c2bd71b
f36306e
6f374be
b3d4e26
f6c7866
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just considerable amounts of RAM. There may be a cost in some implementations to compile each regex (Caches up to 512) and there will be a cost to run 512x500~ regexes against federating servers. So someone could probably put considerable load on the server just by abusing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes a lower limit might be considered as a means of mittigating the abuse potential. Tho if i might add. Its already possible to use ACL to create server load but yes i do agree this MSC makes it ludicrously easier to do since it will expand the amount of server load a single room can create by a factor of atleast 512 if we choose to make 512 slots the standard.
I am completetely open to defining the v1-9 max at a lower number in the 32-128 range to limit the abuse potential and still keep the benefits of this MSC. The max is tied to room versions after all so we can change it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This concern should be alleviated since the slot count is now at a max of 32. It can be made even lower if we think that is desired since a slot count as low as 4-8 still has a massive impact on how much ACL capacity we have.