Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3735: Add device information to m.room_key.withheld message #3735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Feb 18, 2022

@uhoreg uhoreg changed the title MSCxxxx: Add device information to m.room_key.withheld message MSC3735: Add device information to m.room_key.withheld message Feb 18, 2022
@uhoreg uhoreg added client-server Client-Server API e2e needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal proposal-in-review labels Feb 18, 2022
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Feb 23, 2022
Comment on lines +20 to +21
- `from_device`: the device ID of the device sending the `m.room_key.withheld`
message (this is the same field name used in key verification)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth noting that there is a sender_key property which maybe we could use for this, though tbh from_device is probably more convenient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API e2e kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants