MSC3735: Add device information to m.room_key.withheld message#3735
Open
uhoreg wants to merge 2 commits into
Open
MSC3735: Add device information to m.room_key.withheld message#3735uhoreg wants to merge 2 commits into
uhoreg wants to merge 2 commits into
Conversation
uhoreg
changed the title
uhoreg
added
A-Client Server
12 tasks
richvdh
reviewed
Jul 5, 2024
Comment on lines
+20
to
+21
| - `from_device`: the device ID of the device sending the `m.room_key.withheld` | ||
| message (this is the same field name used in key verification) |
Member
There was a problem hiding this comment.
worth noting that there is a sender_key property which maybe we could use for this, though tbh from_device is probably more convenient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Preview: https://pr3735--matrix-org-previews.netlify.app