Skip to content

MSC3743: Standardized error response for unknown endpoints#3743

Merged
turt2live merged 10 commits into
mainfrom
clokep/unknown-endpoints
Oct 31, 2022
Merged

MSC3743: Standardized error response for unknown endpoints#3743
turt2live merged 10 commits into
mainfrom
clokep/unknown-endpoints

Conversation

@clokep
Copy link
Copy Markdown
Member

@clokep clokep commented Feb 23, 2022 •
edited
Loading

@clokep clokep changed the title MSC3742: Standardized error response for unknown endpoints MSC3743: Standardized error response for unknown endpoints Feb 23, 2022
@clokep clokep force-pushed the clokep/unknown-endpoints branch from 2ebd911 to a34b675 Compare February 23, 2022 19:11
@turt2live turt2live added A-Client Server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal. Process state. proposal-in-review labels Feb 23, 2022
clokep
clokep commented Feb 23, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md
@ShadowJonathan ShadowJonathan mentioned this pull request Feb 24, 2022
Open
ShadowJonathan
ShadowJonathan reviewed Feb 24, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md
@clokep clokep mentioned this pull request Feb 24, 2022
Merged
progval
progval reviewed May 7, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
@clokep @progval
Fix typo.
4e14040 
Co-authored-by: Val Lorentz <progval+github@progval.net>
timokoesters
timokoesters reviewed Jul 13, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
deepbluev7
deepbluev7 reviewed Jul 29, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Oct 13, 2022

Argh. We really need to make this be a thing.

richvdh
richvdh reviewed Oct 14, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
richvdh
richvdh reviewed Oct 14, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
@clokep clokep requested a review from richvdh October 14, 2022 14:35
@clokep
Copy link
Copy Markdown
Member Author

clokep commented Oct 14, 2022

Argh. We really need to make this be a thing.

I've updated this a bit, the tl;dr of what would need to happen to make it a reality:

  • Dendrite needs to implement it for S-S.
  • Conduit-next is compliant.
  • Synapse needs to go 400 -> 404.

I can put up a Synapse implementation if you need that to move forward.

clokep
clokep commented Oct 14, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md Outdated
clokep
clokep commented Oct 14, 2022
View reviewed changes
Comment thread proposals/3743-errors-for-unknown-endpoints.md
@turt2live turt2live self-requested a review October 14, 2022 17:17
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Oct 26, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period Process state to accept, reject, or postpone an MSC. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels Oct 26, 2022
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Oct 31, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period FCP has finished. Process state. and removed disposition-merge Process state. final-comment-period Process state to accept, reject, or postpone an MSC. labels Oct 31, 2022
@turt2live turt2live merged commit 0ff35b2 into main Oct 31, 2022
@turt2live turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Oct 31, 2022
@MadLittleMods MadLittleMods mentioned this pull request Nov 7, 2022
Closed
@clokep clokep mentioned this pull request Nov 17, 2022
Merged
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 17, 2022

Spec PR: matrix-org/matrix-spec#1347

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Nov 17, 2022
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 22, 2022

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Nov 22, 2022
@clokep clokep deleted the clokep/unknown-endpoints branch November 22, 2022 15:54
@clokep clokep restored the clokep/unknown-endpoints branch November 22, 2022 15:55
@turt2live turt2live mentioned this pull request Nov 30, 2022
Merged
4 tasks
@clokep clokep mentioned this pull request Dec 2, 2022
Closed
@DMRobertson DMRobertson mentioned this pull request Feb 9, 2023
Merged
@zecakeh zecakeh mentioned this pull request Feb 10, 2023
Closed
34 tasks
@clokep clokep mentioned this pull request Feb 17, 2023
Closed
8 tasks
@clokep clokep deleted the clokep/unknown-endpoints branch May 17, 2023 12:20
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
11 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
11 tasks
@ShadowJonathan ShadowJonathan mentioned this pull request Jul 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turt2live turt2live turt2live approved these changes

@richvdh richvdh richvdh approved these changes

+6 more reviewers

@neilalexander neilalexander neilalexander left review comments

@progval progval progval left review comments

@jplatte jplatte jplatte left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

@timokoesters timokoesters timokoesters left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@clokep clokep

Labels

A-Client Server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Status: Merged/Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@clokep @richvdh @turt2live @mscbot @neilalexander @progval @jplatte @deepbluev7 @ShadowJonathan @timokoesters