Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3743: Standardized error response for unknown endpoints #3743

Merged
merged 10 commits into from Oct 31, 2022
Merged

MSC3743: Standardized error response for unknown endpoints #3743

merged 10 commits into from Oct 31, 2022
+189 −0

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Feb 23, 2022 •
edited

@clokep clokep changed the title MSC3742: Standardized error response for unknown endpoints MSC3743: Standardized error response for unknown endpoints Feb 23, 2022
@turt2live turt2live added client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal proposal-in-review labels Feb 23, 2022
@ShadowJonathan ShadowJonathan mentioned this pull request Feb 24, 2022
Open
@clokep clokep mentioned this pull request Feb 24, 2022
Merged
@clokep @progval
Fix typo.
4e14040 
Co-authored-by: Val Lorentz <progval+github@progval.net>
@ShadowJonathan ShadowJonathan mentioned this pull request Jul 13, 2022
Open
@richvdh
Copy link
Member

richvdh commented Oct 13, 2022

Argh. We really need to make this be a thing.

@clokep clokep requested a review from richvdh October 14, 2022 14:35
@clokep
Copy link
Contributor Author

clokep commented Oct 14, 2022

Argh. We really need to make this be a thing.

I've updated this a bit, the tl;dr of what would need to happen to make it a reality:

  • Dendrite needs to implement it for S-S.
  • Conduit-next is compliant.
  • Synapse needs to go 400 -> 404.

I can put up a Synapse implementation if you need that to move forward.

@mscbot
Copy link
Collaborator

mscbot commented Oct 26, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 26, 2022
@mscbot
Copy link
Collaborator

mscbot commented Oct 31, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 31, 2022
@turt2live turt2live merged commit 0ff35b2 into main Oct 31, 2022
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Oct 31, 2022
@turt2live turt2live moved this from Ready for FCP ticks to Requires spec writing in Spec Core Team Backlog Oct 31, 2022
@MadLittleMods MadLittleMods mentioned this pull request Nov 7, 2022
Closed
@clokep clokep mentioned this pull request Nov 17, 2022
Merged
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1347

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Nov 17, 2022
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Nov 22, 2022
@turt2live turt2live moved this from Requires spec writing to Done to some definition in Spec Core Team Backlog Nov 22, 2022
@clokep clokep deleted the clokep/unknown-endpoints branch November 22, 2022 15:54
@clokep clokep restored the clokep/unknown-endpoints branch November 22, 2022 15:55
@turt2live turt2live mentioned this pull request Nov 30, 2022
Merged
4 tasks
@clokep clokep mentioned this pull request Dec 2, 2022
Closed
@DMRobertson DMRobertson mentioned this pull request Feb 9, 2023
Merged
@zecakeh zecakeh mentioned this pull request Feb 10, 2023
Closed
34 tasks
@clokep clokep mentioned this pull request Feb 17, 2023
Closed
8 tasks
@clokep clokep deleted the clokep/unknown-endpoints branch May 17, 2023 12:20
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander left review comments

@progval progval progval left review comments

@jplatte jplatte jplatte left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

@timokoesters timokoesters timokoesters left review comments

@turt2live turt2live turt2live approved these changes

@richvdh richvdh richvdh approved these changes

Assignees

@clokep clokep

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@clokep @richvdh @turt2live @mscbot @neilalexander @progval @jplatte @deepbluev7 @ShadowJonathan @timokoesters