MSC3754: Removing profile information #3754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
turt2live
added
proposal-in-review
proposal
clokep
reviewed
Jun 16, 2024
Comment on lines
+24
to
+26
| To identify the change, the `m.room.member` and `m.presence` events sent following the call to one of these two | ||
| endpoints MUST include the changed key with a `null` value. Subsequent `m.room.member` events SHOULD omit the deleted | ||
| key altogether. |
There was a problem hiding this comment.
Why must the m.room.member eventsinclude null instead of omitting the values? The current spec for m.room.member and m.presence for these fields is pretty clear:
The {avatar URL|display name} for this user, if any.
My reading of this is that the new values fully replace any old values and omitted values should be cleared.
Note that I think https://spec.matrix.org/v1.10/client-server-api/#events-on-change-of-profile-information is the useful part of the spec we're talking about? Cross-linking in the MSC is very much appreciated.
clokep
reviewed
Jun 16, 2024
Comment on lines
+44
to
+46
| The `m.room.member` event omits the changed key in `content`. This means that all the keys that are not unset should be | ||
| present every time a part of the profile is changed. This is limiting for custom keys as they might be omitted by | ||
| clients or servers that don't recognize them. |
There was a problem hiding this comment.
I'm not really following this, maybe fewer double negatives helps?
Suggested change
| The `m.room.member` event omits the changed key in `content`. This means that all the keys that are not unset should be | |
| present every time a part of the profile is changed. This is limiting for custom keys as they might be omitted by | |
| clients or servers that don't recognize them. | |
| The `m.room.member` event omits the changed key in `content`. This means that all the keys that ar set should be | |
| present every time a part of the profile is changed. This is limiting for custom keys as they might be omitted by | |
| clients or servers that don't recognize them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Related spec issues: