Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3817: Allow widgets to create rooms #3817

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dhenneke
Copy link

@dhenneke dhenneke commented May 17, 2022

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke dhenneke marked this pull request as ready for review May 17, 2022 15:45
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also sign off on all of your commits, either by rebasing while early in review here or using the PR description to put the Signed-off-by attribute.

proposals/3817-widget-api-create-rooms.md Outdated Show resolved Hide resolved
@turt2live turt2live added proposal A matrix spec change proposal kind:feature MSC for not-core and not-maintenance stuff widgets anything to do with widgets needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels May 17, 2022
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke dhenneke force-pushed the nic/feat/widgetapi-create-room branch from e7fc632 to ccd90eb Compare May 17, 2022 15:50
@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label May 20, 2022
@dhenneke
Copy link
Author

@turt2live How do we want to move forward here?

If you agree with the proposal, I can prepare the required PRs in the other repositories.

@turt2live
Copy link
Member

@dhenneke the next steps for this MSC would be getting review from the community and Spec Core Team (SCT, which includes myself). Once that review has been done then we'll take a look at getting the changes incorporated into the spec, though for widgets this is typically pretty slow due to the shear size of the feature (unfortunately). The place to seek that review is #matrix-spec:matrix.org on Matrix.

If you're more concerned with the capability being added to the widget-api and react-sdk projects respectively, there's some potential changes to which team is responsible for maintaining widgets coming up. I'll have more information in the next few weeks (hopefully) - ping me in #matrix-widgets:matrix.org after July 13th or so and we can go from there. (or, if there's something more urgent than that needed, let me know and we'll figure it out).

@dhenneke
Copy link
Author

dhenneke commented Aug 4, 2022

I cleaned up our prototype implementation and created the respective draft pull requests.

We would really like to see this going forward, meaning getting into the widget-api and react-sdk so we can work with it in our widgets.

@turt2live turt2live self-assigned this Aug 4, 2022
@@ -0,0 +1,149 @@
# MSC3817: Allowing widgets to create rooms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any desire to require widgets to request the user's permission per room type that they'd like to create? For instance, I'd possibly be happy with a widget creating lots of m.calendar.event type rooms, but less happy for it to have the ability to create Spaces.

Copy link
Author

@dhenneke dhenneke Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that could be reasonable. There could be a m.create_room (or m.create_room:?) capability to add a room without a type, and m.create_room:<room-type> for specific types. I'm not sure if there would be a use case for a m.create_room:* capability. Say someone builds a generic room manager widget for some reason, it could also make use of MSC2974 to request that on demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal widgets anything to do with widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants