Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3844: Remove unused policy room sharing mechanism #3844

Merged
merged 1 commit into from Jul 25, 2022
Merged

MSC3844: Remove unused policy room sharing mechanism #3844

merged 1 commit into from Jul 25, 2022

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 11, 2022 •
edited by richvdh

@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec labels Jul 11, 2022
@turt2live
Copy link
Member Author

not considering for needs-implementation because, well, it deletes stuff.

This also seems pretty uncontroversial:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jul 11, 2022 •
edited by ara4n

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@turt2live turt2live marked this pull request as ready for review July 11, 2022 21:56
@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 11, 2022
@turt2live turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation Jul 11, 2022
@turt2live turt2live moved this from Needs idea feedback / initial review to Ready for FCP ticks in Spec Core Team Backlog Jul 11, 2022
@turt2live turt2live mentioned this pull request Jul 11, 2022
Closed
@mscbot
Copy link
Collaborator

mscbot commented Jul 19, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 19, 2022
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Jul 19, 2022
@mscbot
Copy link
Collaborator

mscbot commented Jul 24, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 24, 2022
@anoadragon453 anoadragon453 merged commit 1ec0d58 into main Jul 25, 2022
@anoadragon453 anoadragon453 deleted the travis/msc/remove-mjolnir-sharing branch July 25, 2022 12:10
@anoadragon453 anoadragon453 added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 25, 2022
@anoadragon453 anoadragon453 moved this from In FCP to Requires spec review (post-FCP) in Spec Core Team Backlog Jul 25, 2022
@anoadragon453 anoadragon453 moved this from Requires spec review (post-FCP) to Done to some definition in Spec Core Team Backlog Jul 25, 2022
@turt2live turt2live self-assigned this Aug 2, 2022
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 2, 2022
@turt2live
Remove unused policy room sharing mechanism, as per MSC3844
65c5b95 
MSC: matrix-org/matrix-spec-proposals#3844
@turt2live turt2live mentioned this pull request Aug 2, 2022
Merged
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1196

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Aug 2, 2022
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 3, 2022
@turt2live
Remove unused policy room sharing mechanism, as per MSC3844 (#1196)
3c45c0a 
MSC: matrix-org/matrix-spec-proposals#3844
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Aug 3, 2022
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turt2live @mscbot @anoadragon453