Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3909: Membership based mutes #3909

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

FSG-Cat
Copy link
Contributor

@FSG-Cat FSG-Cat commented Oct 13, 2022

Rendered

MSC Co Authored by @FSG-Cat and @Gnuxie

Signed-off-by: Catalan Lover catalanlover@protonmail.com

@FSG-Cat FSG-Cat changed the title MSCXXXX: Membership based mutes MSC3909: Membership based mutes Oct 13, 2022
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff hacktoberfest-accepted needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Oct 13, 2022
Co-authored-by: Aminda Suomalainen <suomalainen+git@mikaela.info>
@luxaritas
Copy link

luxaritas commented Jan 30, 2023

I wonder if there's another way to approach this that would allow users to rejoin as muted (which I would want to allow from a policy perspective with how I use mutes, personally - eg imagine if #55 is implemented and I do an IP mute space-wide of a classroom because of misbehavior but still want them to see activity). What would be the tradeoffs of a separate leave-mute membership type, or separate state to indicate mute status? I guess the latter feels a bit in the direction of RBAC, though from a semantic point of view the line between "permission" and "membership status" is a bit fuzzy.

@@ -0,0 +1,88 @@
# MSC3909: Membership based mutes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luxaritas putting this as a thread as its the correct way to do things.

A leave-mute membership state would actually bypass the issue that requires currently self banning. Because the rule could be that leave is only legal via kick and self leaves are instead leave-mutes and for leave mute the only legal self initiated transition is mute meaning you would essentially gain sticky mutes and bypass this whole self ban stuff. Its quite a good solution to the problem to be honest and it bypasses the whole concern of mine of having to look multiple layers deep in the chain to evaluate legality.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yeah sorry I didn't comment in-line!

FSG-Cat and others added 3 commits March 10, 2023 22:35
Nico pointed out in a conversation the issue of that EDU definition was unclear and that we should allow redactions. Ban transitions where also fixed as they had been overlooked.
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

their membership to `leave-mute` as defined later and `m.room.redaction` events.

This proposal also introduces the new membership type of `leave-mute` this special membership
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec generally seems to use snake_case rather than kebab-case.


their membership to `leave-mute` as defined later and `m.room.redaction` events.

This proposal also introduces the new membership type of `leave-mute` this special membership
Copy link

@Kladki Kladki Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that people would muted users to be able to be invited and knock on rooms, I feel like it might just make more sense to add an additional field to the m.room.member event, rather than having to double the number of membership states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API hacktoberfest-accepted kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants