Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3924: Capability-style access control for Matrix media #3924

Closed
wants to merge 8 commits into from

Conversation

cvwright
Copy link

@cvwright cvwright commented Nov 3, 2022

Rendered

I saw MSC3910 and MSC3911, and those got me thinking about alternative approaches for protecting access to media in the Matrix content repository.

This proposal suggests a different way of looking at the problem, inspired by ideas from capability-based access control.

Signed-off-by: Charles Wright <cvwright@futo.org>
Signed-off-by: Charles Wright <cvwright@futo.org>
Signed-off-by: Charles Wright <cvwright@futo.org>
Signed-off-by: Charles Wright <cvwright@futo.org>
Signed-off-by: Charles Wright <cvwright@futo.org>
@cvwright
Copy link
Author

cvwright commented Nov 3, 2022

Note that this is still a draft, and focuses only on the client-server part of the problem for now.

Suggestion from @deepbluev7

Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de>
@turt2live turt2live changed the title Capability-style access control for Matrix media MSC3924: Capability-style access control for Matrix media Nov 3, 2022
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 3, 2022
@turt2live
Copy link
Member

@cvwright don't forget to sign off on the changes for if this gets accepted please :)

Signed-off-by: Charles Wright <cvwright@futo.org>
@cvwright cvwright marked this pull request as draft November 3, 2022 20:04
Signed-off-by: Charles Wright <cvwright@futo.org>
@turt2live turt2live self-requested a review November 15, 2022 19:26
that addresses this issue by granting media access to events rather than
to rooms.

## Modified Approach: Granting Access via Events Instead of via Rooms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to do something that's event-based because a user in a room may not be allowed to see all the events, and so should not be allowed to see all the media. In addition, if access is only room-based, then new endpoint for listing media in a room may leak information that people should not have access to.


```json
{
"media_ids": ["abc", "def", "xyz"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these be mxc URIs rather than media IDs?

@cvwright
Copy link
Author

cvwright commented Feb 5, 2024

I think MSC3911 covers all the important bits of this, and that one seems to be getting traction, so I'm closing this one

@cvwright cvwright closed this Feb 5, 2024
@turt2live turt2live added the obsolete A proposal which has been overtaken by other proposals label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants