Skip to content

MSC3939: Account locking#3939

Merged
turt2live merged 12 commits into
mainfrom
babolivier/m_locked
May 10, 2024
Merged

MSC3939: Account locking#3939
turt2live merged 12 commits into
mainfrom
babolivier/m_locked

Conversation

@babolivier

@babolivier babolivier commented Nov 24, 2022 •
edited by turt2live
Loading

Copy link
Copy Markdown
Contributor

@babolivier babolivier changed the title MSCXXXX: Account locking MSC3939: Account locking Nov 24, 2022
@turt2live turt2live added proposal A matrix spec change proposal. Process state. A-Client Server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 24, 2022
@aceArt-GmbH

This comment was marked as resolved.

Sign in to view
@babolivier

babolivier commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Seems to overlap a bit with #3823 ;)

See the Alternatives section :)

Also please write comments on MSCs in threads to prevent clottering the timeline 😅

MadLittleMods
MadLittleMods reviewed Apr 15, 2023
View reviewed changes
Comment thread proposals/3939-account-locking.md
@MadLittleMods MadLittleMods mentioned this pull request Apr 15, 2023
Closed
MatMaul
MatMaul reviewed Jul 3, 2023
View reviewed changes
Comment thread proposals/3939-account-locking.md
@babolivier

babolivier commented Jul 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

PSA: I don't really wish to spend time maintaining this MSC anymore (as it was written in the context of work related to a role I no longer hold; plus I don't have write access to this branch anymore). This MSC should be considered unmaintained/abandoned unless someone else wishes to take it over (in which case, be my guest).

@MatMaul MatMaul mentioned this pull request Jul 5, 2023
Merged
4 tasks
@MatMaul

MatMaul commented Jul 5, 2023

Copy link
Copy Markdown

Thanks for your work @babolivier. I am going to take this over.

@MatMaul

MatMaul commented Aug 16, 2023

Copy link
Copy Markdown

An implementation has been merged in synapse and will be available in synapse 1.91.

This was referenced Sep 21, 2023
Open
Merged
turt2live
turt2live reviewed Nov 27, 2023
View reviewed changes
Comment thread proposals/3939-account-locking.md Outdated
@turt2live

turt2live commented Nov 27, 2023

Copy link
Copy Markdown
Member

Aside from some editorial comments, I think this is largely ready to go.

SCT members should feel welcome to comment on the user directory thread.

@mscbot fcp merge

@mscbot

mscbot commented Nov 27, 2023 •
edited by KitsuneRal
Loading

Copy link
Copy Markdown
Collaborator

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • 401/403 behaviour
  • general clarity

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. disposition-merge Process state. labels Nov 27, 2023
@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Nov 27, 2023
dbkr
dbkr reviewed Nov 28, 2023
View reviewed changes
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md Outdated
@dbkr

dbkr commented Nov 28, 2023

Copy link
Copy Markdown
Member

@mscbot concern 401/403 behaviour

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern. Process state. label Nov 28, 2023
@dbkr

dbkr commented Nov 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@mscbot concern general clarity

#3939 (comment) mostly

dklimpel
dklimpel reviewed Nov 28, 2023
View reviewed changes
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md
@turt2live turt2live removed the unresolved-concerns This proposal has at least one outstanding concern. Process state. label Apr 1, 2024
@turt2live

turt2live commented Apr 1, 2024

Copy link
Copy Markdown
Member

I've manually resolved the concerns for now.

@turt2live turt2live mentioned this pull request Apr 1, 2024
Open
uhoreg
uhoreg reviewed Apr 3, 2024
View reviewed changes
Comment thread proposals/3939-account-locking.md Outdated
Comment thread proposals/3939-account-locking.md
@turt2live @uhoreg
Update proposals/3939-account-locking.md
a10802d 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
uhoreg
uhoreg reviewed Apr 23, 2024
View reviewed changes
Comment thread proposals/3939-account-locking.md Outdated
@turt2live @uhoreg
Update proposals/3939-account-locking.md
f76d53a 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@mscbot

mscbot commented May 4, 2024

Copy link
Copy Markdown
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period Process state to accept, reject, or postpone an MSC. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels May 4, 2024
@mscbot

mscbot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period FCP has finished. Process state. and removed disposition-merge Process state. final-comment-period Process state to accept, reject, or postpone an MSC. labels May 9, 2024
@turt2live turt2live merged commit 8eb75fe into main May 10, 2024
@turt2live turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels May 10, 2024
@Johennes Johennes mentioned this pull request Aug 20, 2024
Merged
3 tasks
@Johennes

Johennes commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Spec PR: matrix-org/matrix-spec#1934

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Aug 28, 2024
This was referenced Sep 29, 2024
Closed
Merged
@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 30, 2024
@turt2live

turt2live commented Sep 30, 2024

Copy link
Copy Markdown
Member

Merged 🎉

This was referenced Oct 8, 2024
Closed
Closed
@Half-Shot Half-Shot mentioned this pull request Apr 16, 2025
Open
@n0emis n0emis mentioned this pull request Mar 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live left review comments

@richvdh richvdh richvdh left review comments

@tulir tulir tulir left review comments

@KitsuneRal KitsuneRal KitsuneRal left review comments

@dbkr dbkr Awaiting requested review from dbkr

+3 more reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

@MatMaul MatMaul MatMaul left review comments

@dklimpel dklimpel dklimpel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

A-Client Server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Status: Merged/Done
[Temp] SCT MSC intake board
Status: Scheduled - v1.10

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.