Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4030: Progressive image in Matrix #4030

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

MSC4030: Progressive image in Matrix #4030

wants to merge 9 commits into from

Conversation

ru-ka
Copy link

@ru-ka ru-ka commented Jun 14, 2023

turt2live
turt2live reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ru-ka when you get a chance, please sign off on your changes. This is one of the criteria for the MSC to enter FCP.

proposals/MSC4030: Progressive images in Matrix.md Outdated Show resolved Hide resolved
proposals/MSC4030: Progressive images in Matrix.md Outdated Show resolved Hide resolved
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jun 14, 2023
ru-ka and others added 2 commits June 15, 2023 01:05
@InezMc
Copy link

InezMc commented Jun 15, 2023

Private sign off recieved to dco@matrix.org from @ru-ka and recorded.

@ru-ka @PaarthShah
Grammar corrections
ff44080 
Co-authored-by: Paarth Shah <mail@shahpaarth.com>
turt2live
turt2live reviewed Dec 16, 2023
View reviewed changes
proposals/MSC4030: Progressive images in Matrix.md Outdated

This distinction exists because server-side generated thumbnails cannot be served in encrypted rooms or for media types other than `m.image`.

### Reasons behind API changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MSC appears to have missed a section where it describes what the API changes are.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MSC appears to have missed a section where it describes what the API changes are.

It probably was an oversight. I'll correct the MSC ASAP.

@Mikaela Mikaela mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@PaarthShah PaarthShah PaarthShah left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ru-ka @InezMc @turt2live @PaarthShah