Merge pull request #1035 from thomaslantern/thomasws_branch

removed m.room.message.feedback
matrix-org · May 5, 2022 · 2997c90 · 2997c90
2 parents a164302 + 3c4b658
commit 2997c90
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 45 deletions.
diff --git a/changelogs/client_server/newsfragments/1035.clarification b/changelogs/client_server/newsfragments/1035.clarification
@@ -0,0 +1 @@
+Removed `m.room.message.feedback` per [MSC3582](https://github.com/matrix-org/matrix-spec-proposals/pull/3582).
diff --git a/content/client-server-api/modules/instant_messaging.md b/content/client-server-api/modules/instant_messaging.md
@@ -12,17 +12,6 @@ room itself such as a room name and topic.
 
 {{% event event="m.room.message" %}}
 
-{{% event event="m.room.message.feedback" %}}
-
-Usage of this event is discouraged for several reasons:
--   The number of feedback events will grow very quickly with the number
-    of users in the room. This event provides no way to "batch"
-    feedback, unlike the [receipts module](#receipts).
--   Pairing feedback to messages gets complicated when paginating as
-    feedback arrives before the message it is acknowledging.
--   There are no guarantees that the client has seen the event ID being
-    acknowledged.
-
 {{% event event="m.room.name" %}}
 
 {{% event event="m.room.topic" %}}

diff --git a/data/event-schemas/examples/m.room.message.feedback.yaml b/data/event-schemas/examples/m.room.message.feedback.yaml
diff --git a/data/event-schemas/schema/m.room.message.feedback.yaml b/data/event-schemas/schema/m.room.message.feedback.yaml