Skip to content

Commit

Permalink
Add some safety to the proposals script (#1368)
Browse files Browse the repository at this point in the history
* Add some safety to the proposals script

for if github's api explodes, forgets the header, or we are rate limited or something.

* changelog
  • Loading branch information
turt2live committed Dec 8, 2022
1 parent 9555cbe commit 8a555fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelogs/internal/newsfragments/1368.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve safety of the proposals retrieval script in the event of failure.
2 changes: 1 addition & 1 deletion scripts/proposals.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ async function getIssues() {
const issuesForPage = await response.json();
issues = issues.concat(issuesForPage);
const linkHeader = response.headers.get("link");
pageLink = getNextLink(linkHeader);
pageLink = !!linkHeader ? getNextLink(linkHeader) : null;
}
}

Expand Down

0 comments on commit 8a555fb

Please sign in to comment.