Skip to content

Commit

Permalink
Send heroes for nameless rooms on send_join (#1425)
Browse files Browse the repository at this point in the history
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
  • Loading branch information
uhoreg and clokep committed Feb 7, 2023
1 parent 5c485ad commit e9a463d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/1425.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Note that `/_matrix/federation/v2/send_join` should include heroes for nameless rooms, even when allowed to omit membership events, per [MSC3943](https://github.com/matrix-org/matrix-doc/pull/3943).
10 changes: 10 additions & 0 deletions data/api/server-server/joins-v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ paths:
If `true`, indicates that that calling server can accept a reduced
response, in which membership events are omitted from `state` and
redundant events are omitted from `auth_chain`.
If the room to be joined has no `m.room.name` nor
`m.room.canonical_alias` events in its current state, the resident
server should determine the room members who would be included in
the `m.heroes` property of the room summary as defined in the
[Client-Server /sync
response](/client-server-api/#get_matrixclientv3sync). The resident
server should include these members' membership events in the
response `state` field, and include the auth chains for these
membership events in the response `auth_chain` field.
x-addedInMatrixVersion: "1.6"
- in: body
name: body
Expand Down

0 comments on commit e9a463d

Please sign in to comment.