Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push rule for m.room.server_acl #1190

Merged
merged 2 commits into from Aug 2, 2022
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 2, 2022

@richvdh richvdh requested a review from a team as a code owner August 2, 2022 12:14
@turt2live turt2live added this to Requires spec review (post-FCP) in Spec Core Team Backlog Aug 2, 2022
@turt2live turt2live merged commit f24cad1 into main Aug 2, 2022
@turt2live turt2live deleted the rav/server_acl_push_rule branch August 2, 2022 22:53
@turt2live turt2live moved this from Requires spec review (post-FCP) to Done to some definition in Spec Core Team Backlog Aug 2, 2022
@SimonBrandner
Copy link

Thank you!!

@@ -520,6 +520,33 @@ Definition:
}
```

**`.m.rule.room.server_acl`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this note somewhere that it was changed in 1.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bother! I had one job...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably pin this one on the reviewer than the author.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Spec Core Team Backlog
  
Done to some definition
Development

Successfully merging this pull request may close these issues.

None yet

4 participants