Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add push rule for m.room.server_acl #1190

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Add push rule for m.room.server_acl #1190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85491d8
Add push rule for `m.room.server_acl`
richvdh Aug 2, 2022
4dbed79
Update changelogs/client_server/newsfragments/1190.feature
turt2live Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1190.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a `.m.rule.room.server_acl` push rule to match `m.room.server_acl` events, per [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786).
turt2live marked this conversation as resolved.
Show resolved Hide resolved
27 changes: 27 additions & 0 deletions content/client-server-api/modules/push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,33 @@ Definition:
}
```

**`.m.rule.room.server_acl`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this note somewhere that it was changed in 1.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bother! I had one job...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably pin this one on the reviewer than the author.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1201


Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events.

Definition:

```json
{
"rule_id": ".m.rule.room.server_acl",
"default": true,
"enabled": true,
"conditions": [
{
"kind": "event_match",
"key": "type",
"pattern": "m.room.server_acl"
},
{
"kind": "event_match",
"key": "state_key",
"pattern": ""
}
],
"actions": []
}
```

**`.m.rule.roomnotif`**

Matches any message whose content is unencrypted and contains the text
Expand Down