Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require access_token, device_id and user_id fields in /login response #1210

Merged
merged 2 commits into from Aug 16, 2022
Merged

Require access_token, device_id and user_id fields in /login response #1210

merged 2 commits into from Aug 16, 2022

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Aug 12, 2022 •
edited by github-actions bot

@anoadragon453 anoadragon453 force-pushed the anoa/login_required_response_items branch from 7cd8509 to 6070856 Compare August 12, 2022 13:52
@anoadragon453 anoadragon453 marked this pull request as ready for review August 12, 2022 13:54
@anoadragon453 anoadragon453 requested a review from a team as a code owner August 12, 2022 13:54
richvdh
richvdh approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anoadragon453 anoadragon453 merged commit 5572d33 into main Aug 16, 2022
@anoadragon453 anoadragon453 deleted the anoa/login_required_response_items branch August 16, 2022 17:12
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login/register endpoints say the device_id and stuff aren't required in the response
2 participants
@anoadragon453 @richvdh