Receipts: Add thread_id to the /receipt endpoint
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
force-pushed
the
thread-receipt-endpoint
branch
from
d82135f
to
174fcf2
Compare
turt2live
reviewed
Oct 2, 2022
Co-authored-by: Travis Ralston <travpc@gmail.com>
turt2live
approved these changes
Oct 4, 2022
|
hmm, this seems to be missing signoff on all the commits - @zecakeh are you able to provide it? |
|
Signed-off-by: Kévin Commaille zecakeh@tedomum.fr Is this enough? |
|
it is! Thank you. |
turt2live
added a commit
that referenced
this pull request
Oct 4, 2022
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in #1255 Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * changelog Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <travpc@gmail.com> Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> Co-authored-by: Travis Ralston <travpc@gmail.com>
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * changelog Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <travpc@gmail.com> Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to have been omitted in #1255.
Per MSC3771.
Preview: https://pr1261--matrix-spec-previews.netlify.app