add in-room m.key.verification.request msgtype #1271
Conversation
data/event-schemas/schema/m.room.message$m.key.verification.request.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
this makes an example appear under the general definition of m.room.message (https://pr1271--matrix-spec-previews.netlify.app/client-server-api/#mroommessage), which feels confusing to me.
Worse, where there ought to be an example, is just an empty "Examples" heading:
| @@ -562,6 +565,8 @@ in this specification must be under the `m.key.verification` namespace | |||
| and any other event types must be namespaced according to the Java | |||
| package naming convention. | |||
|
|
|||
| {{% event event="m.room.message$m.key.verification.request" %}} | |||
There was a problem hiding this comment.
this presents itself as literally m.room.message$m.key.verification.request, which is obscure to say the least:
It's also in conflict to the way that m.text and co are represented, though I'm not sure that format would be terribly useful either:
Maybe the render-event.html template thing needs to be updated to honour the title of the event definition, then we can set that to something like "m.room.message with msgtype: m.key.verification.request" ?
There was a problem hiding this comment.
This and #1271 (comment) will be fixed by #1283
data/event-schemas/schema/m.room.message$m.key.verification.request.yaml
Show resolved
Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
fixes #18
ref: matrix-org/matrix-spec-proposals#2241
Apparently, when in-room verification was added, the
m.key.verification.requestmsgtype was forgotten.Preview: https://pr1271--matrix-spec-previews.netlify.app