Make definition anchors more unique #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stick a `definition-` on the front of the autogenerated anchors for definition blocks. This solves a problem where, for example, https://spec.matrix.org/unstable/application-service-api/#registration could refer to either the "Registration" section or the `Registration` definition therein. (These anchors are relatively recent: they were added in #1191.
anoadragon453
approved these changes
Nov 15, 2022
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Stick a `definition-` on the front of the autogenerated anchors for definition blocks. This solves a problem where, for example, https://spec.matrix.org/unstable/application-service-api/#registration could refer to either the "Registration" section or the `Registration` definition therein. (These anchors are relatively recent: they were added in matrix-org#1191.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stick a
definition-on the front of the autogenerated anchors for definition blocks.This solves a problem where, for example, https://spec.matrix.org/unstable/application-service-api/#registration could refer to either the "Registration" section or the
Registrationdefinition therein.(These anchors are relatively recent: they were added in #1191.)
Preview: https://pr1339--matrix-spec-previews.netlify.app